fix: Make $[], sizeof($) and addressof($) respect the current section + added tests for it - #244
Merged
WerWolv merged 4 commits intoAug 25, 2026
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, $[address] returned a byte from the main section, regardless of the current active section it's being executed in. I'm pretty sure this is a bug because
std::mem::read_unsigned(and other functions instd::mem) actually respects the current section (see here).sizeof($)andaddressof($)were also fixed. They now work exactly the same way asstd::mem::sizeandstd::mem::base_address.Additionally, I added tests for the
$operator since it didn't have its own tests before and I wasn't sure where to put tests for$[],sizeof($)andaddressof($). Small note:#pragma base_addressdoesn't exist here and I'm not sure how to change base address without it, soaddressof($)is not actually being tested with a modified base address.