Fix shell completion value metadata - #5007
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliFlagSchema.--open-issuesgithub+ file behavior.Root cause
Pipe-separated help placeholders were treated as exhaustive enum domains. Mixed and free-form metavariables such as
<name|path>and<path|github|github:owner/name>therefore leaked into generated shell completion candidates as literal values.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore— passed with 0 warnings and 0 errors.CliFlagSchemaTests|ConsoleUiTestsonnet8.0andnet9.0— 301 passed on each target framework.net8.0suite on latestorigin/main— 11,008 passed, 7 skipped, 0 failed.net9.0suite on latestorigin/main— 10,533 passed, 420 skipped; one unrelated high-load MCP audit test failed only during concurrent dual-TFM execution and passed the immediate bounded isolated retry (1/1). A prior sequential fullnet9.0run also completed without failures.dotnet format CodeIndex.sln --verify-no-changes --no-restore— passed.dotnet run --project tools/CodeIndex.Changelog -c Release --no-build -- check— validated 78 fragments.github+ file candidates, and quoted paths containing spaces.status --check --jsonreportsindex_matches_workspace: true.Adversarial review
Ran the required Codex adversarial review for two rounds. Addressed both actionable findings: Fish now consumes command-specific value domains, and PowerShell delegates path values to its native filename completer so nested path prefixes and quoting are preserved.
Fixes #4902