Avoid duplicate unused symbols in by-bucket JSON - #5010
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 31, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symbolsarray and representby_bucketmembership with lightweight symbol-index references.by_bucket_formatcontracts in CLI and MCP JSON, while preserving unknown-bucket completeness.unused --max-json-bytessupport with exact UTF-8 budgeting, gap-free byte-truncated pagination, bounded database errors, and readiness metadata derived from emitted rows.Root cause and impact
The full
unused --json --by-bucketresponse serialized complete symbol objects both in the main result set and again in every bucket, so response size grew with duplicated data. The unused command also lacked a byte-budgeted pagination path. Consumers can now reconstruct bucket membership without duplicated full rows and safely page large responses under a requested JSON byte limit.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore(0 warnings, 0 errors)dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-build --no-restore --logger "console;verbosity=minimal"make lintDocumentation and changelog
README.mdandTESTING_GUIDE.md.changelog.d/unreleased/4904.fixed.md.Follow-up candidates
None.
Fixes #4904