Restore common versioned envelope for validate count JSON - #5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate --format countthrough the shared versioned count envelope while retaining the legacytotal_estimatedfield and pre-limit count semanticsRoot cause
The validate count fast path called the legacy formatted-count writer directly, bypassing the canonical count-envelope builder and validate-specific readiness metadata.
Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=falsenet8.0andnet9.0(4/4 passed on each target after the finalorigin/mainmerge)net8.0Release suite: 11,029 passed, 7 skipped, 1 unrelated load-sensitive failure; the failing Unicode worker test passed in isolationnet9.0Release suite: 10,555 passed, 420 skipped, 1 unrelated timeout; the failing parallel batch-refresh test passed in isolationdotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --no-build -c Release --project tools/CodeIndex.Changelog -- checkFixes #4908