Skip to content

Restore common versioned envelope for validate count JSON - #5014

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue4908
Jul 31, 2026
Merged

Restore common versioned envelope for validate count JSON#5014
Widthdom merged 4 commits into
mainfrom
fix-issue4908

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • route validate --format count through the shared versioned count envelope while retaining the legacy total_estimated field and pre-limit count semantics
  • expose query scope, filters, freshness, validation-data readiness, index completion, and authoritative/degraded state, including unavailable legacy severity filters
  • document the contract in both English and Japanese and add the required changelog fragment

Root cause

The validate count fast path called the legacy formatted-count writer directly, bypassing the canonical count-envelope builder and validate-specific readiness metadata.

Validation

  • dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false
  • focused Issue Restore the common versioned envelope for validate count JSON #4908 tests on net8.0 and net9.0 (4/4 passed on each target after the final origin/main merge)
  • full net8.0 Release suite: 11,029 passed, 7 skipped, 1 unrelated load-sensitive failure; the failing Unicode worker test passed in isolation
  • full net9.0 Release suite: 10,555 passed, 420 skipped, 1 unrelated timeout; the failing parallel batch-refresh test passed in isolation
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • dotnet run --no-build -c Release --project tools/CodeIndex.Changelog -- check
  • Codex adversarial review, including a second round after addressing the legacy severity-schema finding: no remaining correctness, security, or regression issues

Fixes #4908

@Widthdom
Widthdom marked this pull request as ready for review July 31, 2026 15:21
@Widthdom
Widthdom merged commit 4c391bf into main Jul 31, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue4908 branch July 31, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore the common versioned envelope for validate count JSON

1 participant