Repository navigation
test(oidc): unskip TestHandleCallback_AutoProvisionsNewUserWithDefaultGroup - #40
Merged
Merged
Conversation
… master PR #27 (V2-273) merged the nullableAddedBy() fix that this test's t.Skip was waiting on. The test passes locally with -count=1 after dropping the skip; the original FK-violation path is gone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #27 (V2-273) added the `nullableAddedBy()` translation that this test was waiting on (`addedBy=0` sentinel → SQL NULL, fixing the FK violation in the auto-provision path). #27 merged earlier today, so the skip is now stale.
Verified locally with `go test ./internal/services -run TestHandleCallback_AutoProvisionsNewUserWithDefaultGroup -count=1` — passes in 3s.
Test plan
🤖 Generated with Claude Code