Documentation updates - #256
Conversation
Co-Authored-By: Javier Casares <javier@casares.org>
Co-Authored-By: Javier Casares <javier@casares.org>
This will be hanlded in #254 instead.
Co-Authored-By: Javier Casares <javier@casares.org>
Co-Authored-By: Javier Casares <javier@casares.org>
There was a problem hiding this comment.
Looks great! Thank you for doing all this, the clarifying comments etc.
This is the tiniest thing -- Line 154 of readme.md is still a bit awkward. Maybe it could say "This example uses the /home/wptestrunner/ folder..."
On line 156, 166 and 436 are we removing the bash part of ```bash because those commands are linux cli and not bash? (for example bash doesn't support a vim or vi command) -- or is there another reason? Should we put a ```linux cli highlight there instead?
Thanks!
This makes the following improvements: - Ensure each function, and file have a proper short description. - Use third-person singular verbs for function summaries. - Enforces the 80 character limit (120 when indentation is present) for DocBlocks. - Code should be self-documenting. Avoid explaining every step of the code. - Multi-line inline comments should start with `/*` not `/**`. Co-Authored-By: Javier Casares <javier@casares.org>
|
Thanks! I still have a few more changes I'd like to make. When I created this PR, I started by copying every documentation change unrelated to adding support for mult-php/multi-commit from the other pull request and my plan was to make any further changes for consistency, and pose some discussion points within the code here. The README file is still on my to do list. The reason for removing the syntax highlighting for |
|
I see! I vote we leave them in in that case. Should we make a different PR for the readme? Re:
|
kittenkamala
left a comment
There was a problem hiding this comment.
I know this is still in progress, but just noticed these:
Co-authored-by: Amy Kamala <39748136+kittenkamala@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Resolve conflicts with documentation updates from WordPress#256 while keeping multi-PHP, environment labels, and commit tracking. Co-authored-by: Cursor <cursoragent@cursor.com>
This splits out the documentation updates from #212 that were unrelated to the overall goals of that pull request.