Skip to content

Documentation updates - #256

Merged
jazzsequence merged 16 commits into
masterfrom
documentation-changes
Aug 16, 2026
Merged

Documentation updates#256
jazzsequence merged 16 commits into
masterfrom
documentation-changes

Conversation

@desrosj

@desrosj desrosj commented Aug 19, 2025

Copy link
Copy Markdown
Member

This splits out the documentation updates from #212 that were unrelated to the overall goals of that pull request.

desrosj and others added 7 commits August 12, 2025 16:12
Co-Authored-By: Javier Casares <javier@casares.org>
Co-Authored-By: Javier Casares <javier@casares.org>
This will be hanlded in #254 instead.
Co-Authored-By: Javier Casares <javier@casares.org>
Co-Authored-By: Javier Casares <javier@casares.org>
@desrosj
desrosj requested a review from javiercasares August 19, 2025 18:50
@desrosj desrosj self-assigned this Aug 19, 2025
@desrosj
desrosj marked this pull request as draft August 19, 2025 19:34

@kittenkamala kittenkamala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for doing all this, the clarifying comments etc.

This is the tiniest thing -- Line 154 of readme.md is still a bit awkward. Maybe it could say "This example uses the /home/wptestrunner/ folder..."

On line 156, 166 and 436 are we removing the bash part of ```bash because those commands are linux cli and not bash? (for example bash doesn't support a vim or vi command) -- or is there another reason? Should we put a ```linux cli highlight there instead?

Thanks!

This makes the following improvements:
- Ensure each function, and file have a proper short description.
- Use third-person singular verbs for function summaries.
- Enforces the 80 character limit (120 when indentation is present) for DocBlocks.
- Code should be self-documenting. Avoid explaining every step of the code.
- Multi-line inline comments should start with `/*` not `/**`.

Co-Authored-By: Javier Casares <javier@casares.org>
@desrosj

desrosj commented Aug 21, 2025

Copy link
Copy Markdown
Member Author

Thanks! I still have a few more changes I'd like to make.

When I created this PR, I started by copying every documentation change unrelated to adding support for mult-php/multi-commit from the other pull request and my plan was to make any further changes for consistency, and pose some discussion points within the code here.

The README file is still on my to do list.

The reason for removing the syntax highlighting for bash there is not clear. The commit that introduced this change did not really explain. I am leaning towards reverting the removal of those unless a good reason presents itself. There possibly are a code examples where the language could be improved.

@kittenkamala

Copy link
Copy Markdown
Contributor

I see! I vote we leave them in in that case. Should we make a different PR for the readme?

Re:

Thanks! I still have a few more changes I'd like to make.

When I created this PR, I started by copying every documentation change unrelated to adding support for mult-php/multi-commit from the other pull request and my plan was to make any further changes for consistency, and pose some discussion points within the code here.

The README file is still on my to do list.

The reason for removing the syntax highlighting for bash there is not clear. The commit that introduced this change did not really explain. I am leaning towards reverting the removal of those unless a good reason presents itself. There possibly are a code examples where the language could be improved.

@kittenkamala kittenkamala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in progress, but just noticed these:

Comment thread prepare.php Outdated
Comment thread prepare.php Outdated
@kittenkamala kittenkamala moved this from Todo to In Progress in WordPress Hosting Team Feb 27, 2026
@kittenkamala kittenkamala added this to the example milestone Feb 27, 2026
@kittenkamala kittenkamala linked an issue Feb 27, 2026 that may be closed by this pull request
@desrosj
desrosj marked this pull request as ready for review August 16, 2026 17:06
@desrosj
desrosj requested a review from kittenkamala August 16, 2026 17:06
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: jazzsequence <jazzs3quence@git.wordpress.org>
Co-authored-by: kittenkamala <amykamala@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jazzsequence jazzsequence moved this from Backlog to Can Merge in Hosting Team WCUS 2026 Aug 16, 2026
@jazzsequence
jazzsequence merged commit 64e9da9 into master Aug 16, 2026
6 checks passed
@jazzsequence
jazzsequence deleted the documentation-changes branch August 16, 2026 21:50
@github-project-automation github-project-automation Bot moved this from Can Merge to Done in Hosting Team WCUS 2026 Aug 16, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in WordPress Hosting Team Aug 16, 2026
dilipom13 added a commit to dilipom13/phpunit-test-runner that referenced this pull request Aug 18, 2026
Resolve conflicts with documentation updates from WordPress#256 while keeping multi-PHP, environment labels, and commit tracking.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

example task related to feature

3 participants