Skip to content

Test coverage seems low #468

Description

@iandunn

I ran an Xdebug report locally and the overall coverage was 34% before #427, and 23% after.

I'm not a coverage zealot, and don't think 100% is a reasonable, but 100% over the critical areas seems reasonable for a security plugin, especially before it becomes a canonical plugin or merges into Core.

sjinks/wp-two-factor-provider-webauthn has some e2e tests that might provide a head start. Adding more unit/integration tests would be nice too.

Using @codeCoverageIgnore on the untestable and low-severity areas would also help make it more obvious if everything that should be covered actually is.

Related: #467

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions