Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The plugin stores per-user authentication records in user meta but did not hook into the WordPress personal data tools added in 4.9.6, so an administrator handling an export or erasure request saw none of it. Exporter reports what is stored without disclosing any of it: enabled and primary methods, TOTP as configured rather than its secret, backup codes as a remaining count rather than codes or hashes, a pending email code by the time it was issued, and the failed-attempt records. Eraser removes the incidental login records — login nonce, failed attempt counter, rate-limit timestamp, password-reset flag, pending email token, TOTP replay timestamp. Credentials are deliberately retained and reported through items_retained: erasing them would turn off the second factor on a live account without the account holder asking for that. They are already removed when the account is deleted, and on uninstall. Providers contribute through two optional methods on the base class, privacy_export_data() and privacy_eraser_user_meta_keys(), mirroring the existing uninstall_user_meta_keys() pattern so core carries no provider-specific logic. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The eraser removed `_two_factor_totp_last_successful_login` but nothing asserted it. Verified the test catches a regression by returning an empty array from Two_Factor_Totp::privacy_eraser_user_meta_keys() and watching it fail before restoring. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dknauss
force-pushed
the
add/privacy-exporter-eraser
branch
from
September 26, 2026 16:05
4fe4213 to
c43c623
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds personal data export and erasure support for Two-Factor.
The export describes stored data without exposing secrets or backup codes. Erasure clears temporary login data and tells the requester when credentials or settings are kept, including credentials for a turned-off method.
Closes #954
Tested:
npm test(205 tests passed).