Fix privacy request confirmation checkbox alignment - #11841
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thank you @deepakpra for the PR and to all the reviewers! |
The margins were set to `0` for all inputs in the request form, breaking the alignment for the checkbox. Limit margin resetting to inputs of type text. Change labeling from implicit to explicit labelling, to better support voice control users. Developed in #11841 Props soyebsalar01, suryakantupadhyay, deepakprajapati, audrasjb, joedolson, adrianduffell, mukesh27, wildworks, masteradhoc. Fixes #65246. git-svn-id: https://develop.svn.wordpress.org/trunk@63011 602fd350-edb4-49c9-b593-d223f7449a82
The margins were set to `0` for all inputs in the request form, breaking the alignment for the checkbox. Limit margin resetting to inputs of type text. Change labeling from implicit to explicit labelling, to better support voice control users. Developed in WordPress/wordpress-develop#11841 Props soyebsalar01, suryakantupadhyay, deepakprajapati, audrasjb, joedolson, adrianduffell, mukesh27, wildworks, masteradhoc. Fixes #65246. Built from https://develop.svn.wordpress.org/trunk@63011 git-svn-id: http://core.svn.wordpress.org/trunk@62230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The margins were set to `0` for all inputs in the request form, breaking the alignment for the checkbox. Limit margin resetting to inputs of type text. Change labeling from implicit to explicit labelling, to better support voice control users. Developed in WordPress#11841 Props soyebsalar01, suryakantupadhyay, deepakprajapati, audrasjb, joedolson, adrianduffell, mukesh27, wildworks, masteradhoc. Fixes #65246. git-svn-id: https://develop.svn.wordpress.org/trunk@63011 602fd350-edb4-49c9-b593-d223f7449a82


What?
Fixes the alignment of the confirmation email checkbox on the Add Data Export Request form.
Why?
The privacy request form was resetting margins for all inputs in
src/wp-admin/css/forms.cssaround line 1578:This overrode the default checkbox/radio margin declared in the same file around line 126:
As a result, the checkbox in
src/wp-admin/export-personal-data.phparound line 130 appeared vertically misaligned with its label.How?
Narrows the privacy request form selector so checkbox and radio inputs keep the default admin form control spacing, while other inputs continue to have their margins reset.
Screenshots
Testing Instructions
Trac
https://core.trac.wordpress.org/ticket/65246
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Testing guidance, CSS fix suggestion. Final changes were reviewed and edited by me.