Skip to content

HTML API: Ensure correct serialization of XMP contents - #12193

Closed
sirreal wants to merge 6 commits into
WordPress:trunkfrom
sirreal:fix/xmp-rawtext-serialize
Closed

HTML API: Ensure correct serialization of XMP contents#12193
sirreal wants to merge 6 commits into
WordPress:trunkfrom
sirreal:fix/xmp-rawtext-serialize

Conversation

@sirreal

@sirreal sirreal commented Jun 16, 2026

Copy link
Copy Markdown
Member

XMP contents are not decoded and should not use HTML character reference escaping when serializing.

Escaping on serialize does not preserve the contents, so sequential normalizations of the original become:

  1. <xmp> < > & " ' ␀ </xmp> (original, ␀ is U+0000 NUL)
  2. <xmp> &lt; &gt; &amp; &quot; &apos; � </xmp>
  3. <xmp> &amp;lt; &amp;gt; &amp;amp; &amp;quot; &amp;apos; � </xmp>
  4. etc…

(Note that the NUL -> � replacement is correct).

See this demo

Note that XMP is an obsolete element, however it is still present in the HTML5 specification.

Relevant specifications:

Parsing in the "in body" insertion mode

A start tag whose tag name is "xmp"

Follow the generic raw text element parsing algorithm.

Serializing HTML fragments

If current node is a Text node
If the parent of current node is a style, script, xmp, iframe, noembed, noframes, or plaintext element, or if the parent of current node is a noscript element and scripting is enabled for the node, then append the value of current node's data literally.

Otherwise, append the value of current node's data, escaped as described below.

Trac ticket: https://core.trac.wordpress.org/ticket/65372

Testing

Compare the HTML API debugger example above on 7.0 with this branch.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude (Opus 4.8, Fable 5), Codex (GPT-5.5)
Used for: Fuzz test implementation, analysis of defects, fix implementation, review.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Jun 22, 2026
The `xmp` element is parsed with the generic raw text element parsing algorithm, so its text content must be appended literally when serializing rather than escaped with HTML character references.

Developed in #12193.

Props jonsurrell.
See #65372.


git-svn-id: https://develop.svn.wordpress.org/trunk@62542 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jun 22, 2026
The `xmp` element is parsed with the generic raw text element parsing algorithm, so its text content must be appended literally when serializing rather than escaped with HTML character references.

Developed in WordPress/wordpress-develop#12193.

Props jonsurrell.
See #65372.

Built from https://develop.svn.wordpress.org/trunk@62542


git-svn-id: http://core.svn.wordpress.org/trunk@61823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@sirreal

sirreal commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Merged in r62542.

@sirreal sirreal closed this Jun 22, 2026
@sirreal
sirreal deleted the fix/xmp-rawtext-serialize branch June 22, 2026 20:29
KhushalSainS pushed a commit to KhushalSainS/wordpress-develop that referenced this pull request Jul 1, 2026
The `xmp` element is parsed with the generic raw text element parsing algorithm, so its text content must be appended literally when serializing rather than escaped with HTML character references.

Developed in WordPress#12193.

Props jonsurrell.
See #65372.


git-svn-id: https://develop.svn.wordpress.org/trunk@62542 602fd350-edb4-49c9-b593-d223f7449a82
SteelWagstaff pushed a commit to SteelWagstaff/wordpress-develop that referenced this pull request Jul 2, 2026
The `xmp` element is parsed with the generic raw text element parsing algorithm, so its text content must be appended literally when serializing rather than escaped with HTML character references.

Developed in WordPress#12193.

Props jonsurrell.
See #65372.


git-svn-id: https://develop.svn.wordpress.org/trunk@62542 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant