Skip to content

Only set absolute positioning in modal #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joedolson wants to merge 3 commits into from
Closed

Only set absolute positioning in modal #12797

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69b07cd
Only set absolute positioning in modal
joedolson Jul 31, 2026
a2c53d6
Adjust position & remove some unneeded CSS duplication CSS.
joedolson Aug 5, 2026
5838571
Set to display flex
joedolson Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/wp-includes/css/media-views.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,9 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
grid-area: 2 / 2 / 3 / 3;
}

.media-toolbar-secondary > .spinner {
.media-modal .media-toolbar-secondary > .spinner {
position: absolute;
left: calc( 100% + 2px );
right: -30px;
top: 50%;
margin: 0;
}
Expand Down Expand Up @@ -1855,6 +1855,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
text-align: right;
text-transform: none;
font-weight: 400;
display: flex;
}

.attachment-details .settings-save-status .spinner {
Expand Down Expand Up @@ -2842,7 +2843,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
float: right;
}

.media-frame .media-toolbar-secondary .spinner {
.media-modal .media-frame .media-toolbar-secondary .spinner {
top: calc( 50% - 8px );

@afercia afercia Aug 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this media query, it still looks misplaced:

Image

@joedolson joedolson Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you suggest as an alternative? The spinner applies to all filters. So aligning it to one or the other feels wrong; this alignment is vertically centered.

@joedolson joedolson Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another alternative would be to set it at calc( 50% - 10px ), and move the position: relative to .media-toolbar instead of .media-toolbar-secondary. That's a relative major change, however, and I'm not sure it's a good idea - there could be unanticipated side effects.

@joedolson joedolson Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, and yes, there are definitely undesirable side effects...

}

Expand Down Expand Up @@ -2877,7 +2878,7 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
bottom: -60px;
}

.media-frame .media-toolbar-secondary .spinner {
.media-modal .media-frame .media-toolbar-secondary .spinner {
top: 0;
}

Expand All @@ -2900,13 +2901,9 @@ select#media-attachment-filters ~ select#media-attachment-date-filters {
position: unset;
}

.media-frame .media-toolbar-secondary .spinner {
position: absolute;
top: 0;
.media-modal .media-frame .media-toolbar-secondary .spinner {
bottom: 0;
margin: auto;
left: calc( 100% + 2px );
right: 0;
z-index: 9;
}

Expand Down
Loading