Skip to content

Administration: Remove no-JS notices from Fonts and Connectors screens - #12946

Closed
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:feature/65840-remove-no-js-notices
Closed

Administration: Remove no-JS notices from Fonts and Connectors screens#12946
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:feature/65840-remove-no-js-notices

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes the per-page no-JS heading and notice added in r62954, since the generated wp-build page template now renders them for every route-based page.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Removing the markup per the ticket; reviewed and verified by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@t-hamano
t-hamano marked this pull request as ready for review August 9, 2026 11:59
@github-actions

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, hbhalodia.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
t-hamano force-pushed the feature/65840-remove-no-js-notices branch from 13fe108 to 93e3978 Compare August 11, 2026 02:03
hbhalodia
hbhalodia approved these changes Aug 11, 2026
View reviewed changes

@hbhalodia hbhalodia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

My initial implementation for the no-js was same 😅. See GB commit - WordPress/gutenberg@caa6795

Based on the comment - https://core.trac.wordpress.org/ticket/65690#comment:5, We decided to add as an admin notice to core instead of GB.

Also, WordPress/gutenberg#81365, This PR has a common message across all pages if there is no JS. Do we need to show the context based message for UX?

@t-hamano

t-hamano commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@hbhalodia Thanks for the review!

Do we need to show the context based message for UX?

I don't think so, as the H1 heading already indicates what the page is about.

pento pushed a commit that referenced this pull request Aug 11, 2026
@t-hamano
Administration: Remove no-JS notices from route-based screens.
3397c1c 
The Fonts and Connectors screens no longer render their own heading and JavaScript-required notice. The generated page template now provides both for every route-based screen, so the per-screen markup only produced a duplicate heading and notice when JavaScript was disabled.

Developed in: #12946

Follow-up to [62954].
Props hbhalodia, wildworks.
Fixes #65840.


git-svn-id: https://develop.svn.wordpress.org/trunk@63174 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63174
GitHub commit: 3397c1c

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Aug 11, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 11, 2026
@t-hamano
Administration: Remove no-JS notices from route-based screens.
b4e6579 
The Fonts and Connectors screens no longer render their own heading and JavaScript-required notice. The generated page template now provides both for every route-based screen, so the per-screen markup only produced a duplicate heading and notice when JavaScript was disabled.

Developed in: WordPress/wordpress-develop#12946

Follow-up to [62954].
Props hbhalodia, wildworks.
Fixes #65840.

Built from https://develop.svn.wordpress.org/trunk@63174


git-svn-id: http://core.svn.wordpress.org/trunk@62371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hbhalodia hbhalodia hbhalodia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @hbhalodia