Backport: Skip pull_request triggered runs in private repos - 5.0 Branch - #13001
Draft
desrosj wants to merge 1 commit into
Draft
Backport: Skip pull_request triggered runs in private repos - 5.0 Branch#13001desrosj wants to merge 1 commit into
desrosj wants to merge 1 commit into
Conversation
This modifies the conditions for GitHub Actions workflow runs so that they do not run within private forks and mirrors for `pull_request` events when the PR is in `draft` status. For situations where this may be desirable, a `Draft Workflow Runs` label can be added to a `draft` pull request to force workflows to run. Props desrosj, jorbin. See #65848. git-svn-id: https://develop.svn.wordpress.org/trunk@63183 602fd350-edb4-49c9-b593-d223f7449a82
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports 15c4b04 (r63183) to the 5.0 branch.
Merge Conflict Resolution
The cherry-pick conflicted because the
5.0branch's.github/workflows/directory predates most of the workflow files and jobs that existed ontrunkat the time of the original commit. Conflicts were resolved as follows:Files that do not exist on the
5.0branch — dropped entirely (not created):.github/workflows/end-to-end-tests.yml.github/workflows/javascript-type-checking.yml.github/workflows/performance.yml.github/workflows/php-compatibility.yml.github/workflows/phpstan-static-analysis.yml.github/workflows/test-and-zip-default-themes.yml.github/workflows/upgrade-develop-testing.yml(noupgrade-testing.yml-style equivalent exists on this branch either).github/workflows/workflow-lint.ymlThe cherry-pick attempted to recreate each of these (git reported them as modify/delete conflicts), so each was removed with
git rmto keep them out of scope for this branch..github/workflows/coding-standards.yml: The5.0branch only has thejshintjob in this workflow — thephpcsjob does not exist yet (PHPCS checking was introduced in WordPress 5.1, per the file's own header comment). The cherry-pick tried to add a newphpcsjob carrying the updated condition; that whole job addition was dropped since it isn't part of this branch. Thejshintjob'sif:condition was updated to the canonical replacement (this part applied cleanly, no hand-editing needed)..github/workflows/javascript-tests.yml: Thetest-jsjob conflicted only because this branch has awith: disable-apparmor: trueblock that trunk no longer has. Resolved by keeping the branch'swith:block and applying the updatedif:condition ahead of it..github/workflows/phpunit-tests.yml: This branch's version of the workflow only has one test job,test-php(usingreusable-phpunit-tests-v1.ymlwith the old PHP-only matrix andsecrets: inherit), plusslack-notificationsandfailed-workflow. Trunk's version has since split into several additional jobs (prepare-gutenberg,test-with-mysql,test-with-mariadb,test-innovation-releases,html-api-test-groups,limited-matrix-for-forks) that do not exist on5.0. Two conflict hunks resulted:test-phpjob'sif:update together with the entirely newtest-with-mysqljob. Keptsecrets: inheritand applied the canonicalif:condition totest-php; dropped thetest-with-mysqljob addition (out of scope).with:block oftest-phpand contained trailingwith:keys (tests-domain,report,gutenberg-artifact,gutenberg-sha) that belong to the newer reusable workflow version, immediately followed by the four other new jobs listed above. All of that was dropped since none of it exists on this branch;test-php's existingwith:block (os,php,phpunit,multisite,split_slow,memcached,phpunit-config) was left untouched and the diff proceeds straight to the existingslack-notificationsjob..github/workflows/test-build-processes.yml: Applied cleanly with no conflicts; only theif:condition was updated.No other files were touched.
git diff upstream/5.0 --statconfirms only these four files under.github/workflows/changed, each changed job now carries the canonical private-repo/draft-PR condition, and every changed YAML file parses successfully with PyYAML.Use of AI Tools
This pull request was created by an AI agent (Claude Code). Until this PR is marked "Ready for Review", treat it as untrusted, AI-created code that requires a manual review by a human team member.