Skip to content

Media: Refresh attachment tile aria-label when model data loads #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sornapudisuresh wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Media: Refresh attachment tile aria-label when model data loads #13053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/js/media/views/attachment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ Attachment = View.extend(/** @lends wp.media.view.Attachment.prototype */{
className: 'attachment',
template: wp.template('attachment'),

attributes: function() {
/**
* Compute the accessible name for an attachment tile.
*
* Factored out of attributes() so render() can refresh the label when a
* model finishes loading after the view was created. See #65852.
*
* @return {string} Accessible name for the attachment.
*/
getAriaLabel: function() {
var ariaLabel = this.model.get( 'title' );

if ( ! ariaLabel ) {
Expand All @@ -28,10 +36,14 @@ Attachment = View.extend(/** @lends wp.media.view.Attachment.prototype */{
}
}

return ariaLabel;
},

attributes: function() {
return {
'tabIndex': 0,
'role': 'checkbox',
'aria-label': ariaLabel,
'aria-label': this.getAriaLabel(),
'aria-checked': false,
'data-id': this.model.get( 'id' )
};
Expand Down Expand Up @@ -157,6 +169,17 @@ Attachment = View.extend(/** @lends wp.media.view.Attachment.prototype */{

this.views.render();

/*
* Backbone only evaluates attributes() when the element is created.
* When a tile is built for an id-only model that is still fetching,
* the aria-label is computed from empty data and never refreshes.
* Re-apply it here once the model has data. Skip subclasses that
* reset attributes (e.g. Attachment.Details). See #65852, #47458.
*/
if ( undefined !== _.result( this, 'attributes' )['aria-label'] ) {
this.$el.attr( 'aria-label', this.getAriaLabel() );
}

return this;
},

Expand Down
Loading