Skip to content

Toolbar: Revert the focus and hover style indication. #13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-hamano wants to merge 3 commits into
base: trunk
Choose a base branch
from
+51 −48
Open

Toolbar: Revert the focus and hover style indication. #13060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac772cc
Revert "Toolbar: Match hover state to focus state."
t-hamano Aug 15, 2026
9d1de6f
Revert "Toolbar: Improve the focus style indication."
t-hamano Aug 15, 2026
92be2f8
Revert "Toolbar: Inconsistent text hover color for top-level nodes."
t-hamano Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/wp-admin/css/admin-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,10 +800,12 @@ li#wp-admin-bar-menu-toggle {
display: block;
padding: 0;
overflow: hidden;
outline: none;
text-decoration: none;
border: 1px solid transparent;
background: none;
height: 46px;
box-sizing: border-box;
height: 44px;
margin-left: -1px;
}

.wp-responsive-open #wpadminbar #wp-admin-bar-menu-toggle a {
Expand All @@ -814,17 +816,22 @@ li#wp-admin-bar-menu-toggle {
display: block;
}

#wpadminbar #wp-admin-bar-menu-toggle a:hover {
border: 1px solid transparent;
}

#wpadminbar #wp-admin-bar-menu-toggle .ab-icon:before {
content: "\f228";
display: inline-block;
float: left;
font: normal 40px/46px dashicons;
font: normal 40px/45px dashicons;
vertical-align: middle;
outline: none;
margin: 0;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
height: 46px;
width: 52px;
height: 44px;
width: 50px;
padding: 0;
border: none;
text-align: center;
Expand Down
32 changes: 15 additions & 17 deletions src/wp-admin/css/colors/_admin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,9 @@ ul#adminmenu > li.current > a.current:after {
background: variables.$menu-submenu-background;
}

#wpadminbar > #wp-toolbar li:hover span.ab-label,
#wpadminbar > #wp-toolbar li.hover span.ab-label,
/* The adminbar menu may output either links or focusable div elements. */
/* As such, we target the focus state without specifying the element type. */
#wpadminbar > #wp-toolbar :focus span.ab-label {
#wpadminbar:not(.mobile) > #wp-toolbar li:hover span.ab-label,
#wpadminbar:not(.mobile) > #wp-toolbar li.hover span.ab-label,
#wpadminbar:not(.mobile) > #wp-toolbar a:focus span.ab-label {
color: variables.$menu-submenu-focus-text;
}

Expand Down Expand Up @@ -451,9 +449,7 @@ ul#adminmenu > li.current > a.current:after {
}

#wpadminbar .quicklinks li .blavatar,
#wpadminbar .menupop .menupop > .ab-item:before,
#wpadminbar.mobile .quicklinks .ab-icon:before,
#wpadminbar.mobile .quicklinks .ab-item:before {
#wpadminbar .menupop .menupop > .ab-item:before {
color: variables.$menu-icon;
}

Expand All @@ -478,17 +474,21 @@ ul#adminmenu > li.current > a.current:after {
color: variables.$menu-submenu-focus-text;
}

// Note that the icon of the site-name item is not wrapped within a span with class ab-icon like other items.
#wpadminbar .quicklinks li a:hover .blavatar,
#wpadminbar .quicklinks li a:focus .blavatar,
#wpadminbar .quicklinks .ab-sub-wrapper .menupop.hover > a .blavatar,
#wpadminbar .menupop .menupop > .ab-item:hover:before,
#wpadminbar.mobile .quicklinks .hover .ab-icon:before,
#wpadminbar.mobile .quicklinks .hover .ab-item:before,
#wpadminbar.mobile .quicklinks .ab-item:focus:before {
#wpadminbar.mobile .quicklinks .hover .ab-item:before {
color: variables.$menu-submenu-focus-text;
}

#wpadminbar.mobile .quicklinks .ab-icon:before,
#wpadminbar.mobile .quicklinks .ab-item:before {
color: variables.$menu-icon;
}


/* Admin Bar: search */

#wpadminbar #adminbarsearch:before {
Expand Down Expand Up @@ -531,16 +531,14 @@ ul#adminmenu > li.current > a.current:after {
color: variables.$menu-text;
}

#wpadminbar #wp-admin-bar-user-info a:hover .display-name {
color: variables.$menu-submenu-focus-text;
}

#wpadminbar #wp-admin-bar-user-info .username {
color: variables.$menu-submenu-text;
}

#wpadminbar #wp-admin-bar-user-info a:hover .display-name,
#wpadminbar #wp-admin-bar-user-info a:focus .display-name,
#wpadminbar #wp-admin-bar-user-info a:hover .username,
#wpadminbar #wp-admin-bar-user-info a:focus .username {
color: variables.$menu-submenu-focus-text;
}

/* Pointers */

Expand Down
50 changes: 24 additions & 26 deletions src/wp-includes/css/admin-bar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,28 +77,12 @@ html:lang(he-il) .rtl #wpadminbar * {
box-shadow: none;
}

#wpadminbar a:focus,
#wpadminbar .ab-item[tabindex="0"]:focus {
outline-offset: -2px;
#wpadminbar a:focus {
outline-offset: -1px;
/* Only visible in Windows High Contrast mode */
outline: 2px solid transparent;
}

#wpadminbar a:hover,
#wpadminbar a:focus,
#wpadminbar .ab-item[tabindex="0"]:hover,
#wpadminbar .ab-item[tabindex="0"]:focus {
box-shadow: inset 0 -4px 0 0 currentColor;
transition: box-shadow 0.1s linear;
}

#wpadminbar .ab-submenu a:hover,
#wpadminbar .ab-submenu a:focus,
#wpadminbar .ab-submenu .ab-item[tabindex="0"]:hover,
#wpadminbar .ab-submenu .ab-item[tabindex="0"]:focus {
box-shadow: inset 4px 0 0 0 currentColor;
}

#wpadminbar {
direction: ltr;
color: #c3c4c7;
Expand Down Expand Up @@ -239,11 +223,9 @@ html:lang(he-il) .rtl #wpadminbar * {
color: #72aee6;
}

#wpadminbar > #wp-toolbar li:hover span.ab-label,
#wpadminbar:not(.mobile) > #wp-toolbar li:hover span.ab-label,
#wpadminbar > #wp-toolbar li.hover span.ab-label,
/* The adminbar menu may output either links or focusable div elements. */
/* As such, we target the focus state without specifying the element type. */
#wpadminbar > #wp-toolbar :focus span.ab-label {
#wpadminbar:not(.mobile) > #wp-toolbar a:focus span.ab-label {
color: #72aee6;
}

Expand Down Expand Up @@ -312,8 +294,7 @@ html:lang(he-il) .rtl #wpadminbar * {
#wpadminbar li.hover .ab-icon:before,
#wpadminbar li.hover .ab-item:before,
#wpadminbar li:hover #adminbarsearch:before,
#wpadminbar li #adminbarsearch.adminbar-focused:before,
#wpadminbar.mobile .quicklinks .ab-item:focus:before {
#wpadminbar li #adminbarsearch.adminbar-focused:before {
color: #72aee6;
}

Expand Down Expand Up @@ -398,6 +379,11 @@ html:lang(he-il) .rtl #wpadminbar * {
float: right;
}

#wpadminbar ul li:last-child,
#wpadminbar ul li:last-child .ab-item {
box-shadow: none;
}

/**
* Recovery Mode
*/
Expand Down Expand Up @@ -466,7 +452,7 @@ html:lang(he-il) .rtl #wpadminbar * {
#wp-admin-bar-user-info .avatar {
position: absolute;
left: -72px;
top: 0;
top: 4px;
width: 64px;
height: 64px;
border-radius: 50%;
Expand All @@ -480,7 +466,7 @@ html:lang(he-il) .rtl #wpadminbar * {
#wpadminbar #wp-admin-bar-user-info span {
background: none;
padding: 0;
line-height: 1.38461538;
height: 18px;
}

#wpadminbar #wp-admin-bar-user-info .display-name,
Expand All @@ -489,6 +475,7 @@ html:lang(he-il) .rtl #wpadminbar * {
}

#wpadminbar #wp-admin-bar-user-info .username {
color: #a7aaad;
font-size: 11px;
}

Expand Down Expand Up @@ -924,6 +911,7 @@ html:lang(he-il) .rtl #wpadminbar * {
overflow: hidden;
width: 52px;
padding: 0;
color: #a7aaad; /* @todo not needed? this text is hidden */
position: relative;
}

Expand Down Expand Up @@ -1043,6 +1031,16 @@ html:lang(he-il) .rtl #wpadminbar * {
height: auto;
font-size: 16px;
line-height: 1.5;
color: #f0f0f1;
}

#wpadminbar #wp-admin-bar-user-info a {
padding-top: 4px;
}

#wpadminbar #wp-admin-bar-user-info .username {
line-height: 0.8 !important;
margin-bottom: -2px;
}

/* Show only default top level items */
Expand Down
Loading