Repository navigation
fix(skills): settle the ci-speed review follow-ups - #328
Merged
Merged
Conversation
- ui-polish: the browser pass asked for touch emulation to show sticky hover, tap highlight and input zoom, but mobile-native section 11 says emulation reproduces none of them; read those fixes in code instead. - ci-speed playbook: put the per-file state reset in a Vitest `setupFiles` entry (rerun before every test file even with `isolate: false`, per the Vitest setupFiles docs) and use `sequence.shuffle`, instead of AGENTS.md prose a tool can enforce. - GLOBAL.md: send slow CI to the ci-speed playbook, since the performance route caught every "make it faster" first.
- GLOBAL.md: yuu-mode is user-invoked, so name the playbook's path on each harness and say it may be read without running /yuu-mode. - ui-polish: point at mobile-native's symptom table instead of restating its fixes, which already got the hover query wrong (it needs `(pointer: fine)` too), and add a real device when connected. - ci-speed: a setupFiles entry only resets what it can import; turn on restoreMocks, unstubGlobals and unstubEnvs, gate isolate: false on a green shuffled run, pin the seed so failures replay, and note shuffle drops Vitest's longest-first ordering (Vitest config docs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #327. Its review left three findings open, and this PR settles them.
Risk: medium.
GLOBAL.mdis the payload every session on every harness loads, and this PR adds one routing line to it. The other two changes are one line each in a skill and in a playbook.What changed
GLOBAL.md: slow CI goes toyuu-mode/playbooks/ci-speed.md, with its path on each harness. Before, the performance route caught every "make it faster", so the playbook was reachable only from inside/yuu-mode.yuu-modeis user-invoked, so the line says the playbook may be read by path.ui-polish/SKILL.md: the minimum browser pass asked for touch emulation to show sticky hover, tap highlight and input zoom.mobile-native/SKILL.md11. Right in Chrome, wrong on phone says emulation reproduces none of them. The pass now reads the fixes inmobile-native's The Symptom Table in code, and uses a real device when one is connected.yuu-mode/playbooks/ci-speed.md: the tests bullet used to put cleanup rules inAGENTS.mdprose. It now relies on Vitest config:restoreMocks,unstubGlobalsandunstubEnvson;setupFilesentry;isolate: falseonly once a shuffled run is green;--sequence.seed, so an order failure replays.Evidence
Sources read this session:
docs/config/setupfiles.md: "If isolation is disabled, imported modules are cached, but the setup file itself is executed again before each test file".restoremocks.md,unstubglobals.mdandunstubenvs.md: each option calls itsvi.*reset "before each test".sequence.md:sequence.seeddefaults toDate.now(), and shuffling loses the cached longest-first order.mobile-native/SKILL.mdhas both cited headings verbatim:## The Symptom Tableand### 11. Right in Chrome, wrong on phone.Which code reads
GLOBAL.md: the sync scripts copy it whole, or compare it whole. The one branch that depends on its content, the OpenCode backup atsync-config.ps1:321, runs only whenAGENTS.local.md.bakis missing. That file exists on this machine.Local CI (
bin/agent-cli check) on3686490:Review (interrogate)
Risky, because the diff touches
GLOBAL.md, a sensitive path in the baseAGENTS.md. Both lenses ran, plus the blast-radius check. The reviewer (opus, high) returned 6 findings, all judgment or grep-backed, with complete coverage.3686490:GLOBAL.mdline named the playbook without a path, so a model could not find a user-invoked skill's file.ui-polishtext restatedmobile-native's fixes and already got one wrong: the hover query also needs(pointer: fine).setupFilesreset as complete. It only reaches state it can import.perf-ratchet's description still says "Use for anything slow" and does not exclude CI. Changing a model-invoked skill's description owes theskill-dietbefore/after eval, and theGLOBAL.mdroute now fires first.ui-polishline. Both changes correct facts against the cited sources, with no behavior variant to compare. Skipping is my call, recorded here.Not verified
skills/ui-polish/update-refs.shran once on the first commit. It printed noUNROUTEDorMISSINGline formobile-native. It was not rerun after the citation changed to The Symptom Table.ELI5
Asking an agent to speed up CI now leads to the CI checklist instead of the app-performance tool.
The phone checks now say what a desktop browser cannot fake, and the test advice uses settings the tool enforces.