[Feat] Add DCG support for macOS x86_64 - #1213
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
navedmerchant
marked this pull request as ready for review
August 9, 2026 22:06
navedmerchant
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 9, 2026 22:06
edelauna
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #N/A — internal request (DCG macOS x86_64 support gap)
Description
Adds Destructive Command Guard (DCG) support for macOS on Intel (x86_64). Previously
getDcgArchiveInfo("darwin", "x64")returnedundefined, so DCG was treated as an unsupported platform on Intel Macs and command guarding could not run there.The change uses the existing
DCG_ARCHIVESplatform-mapping construct insrc/services/destructive-command-guard/constants.ts:darwin-x64entry pointing at the upstreamdcg-x86_64-apple-darwin.tar.xzasset from the pinnedv0.7.7release, with its SHA-256 checksum (15b42fbbbeab47123899e6328d90cd593e14999f3d275f71294815ad8ed9479c). The checksum was verified against the actual downloaded release archive.manager.tsresolvesDCG_ARCHIVES[${platform}-${arch}], sodarwin/x64now resolves automatically through the existing download, checksum-verification, and extraction path.__tests__/manager.spec.tsto includedarwin-x64and assert the archive name mapping.Test Procedure
src/services/destructive-command-guard/__tests__/manager.spec.tsplatform-mapping test now coversdarwin-x64(getDcgArchiveInfo("darwin", "x64")→dcg-x86_64-apple-darwin.tar.xz).vitest run services/destructive-command-guard/__tests__/manager.spec.ts: 17 passed, 1 skipped.pnpm test(turbo, all 10 packages): all tasks successful.eslint --max-warnings=0clean on changed files; pre-commit lint-staged + full turbo lint passed.dcg-x86_64-apple-darwin.tar.xzfrom the pinned v0.7.7 GitHub release and runningshasum -a 256.Pre-Submission Checklist
Visual Snapshots
Not applicable — no user-visible UI change.
Videos (interaction / animation only)
Not applicable.
Documentation Updates
Additional Notes
None.
Get in Touch
Available via @roomote mentions on this PR for follow-up questions.