Skip to content

[Feat] Add DCG support for macOS x86_64 - #1213

Merged
edelauna merged 1 commit into
mainfrom
feat/dcg-darwin-x64-support-07v94zdovar5u
Aug 9, 2026
Merged

[Feat] Add DCG support for macOS x86_64#1213
edelauna merged 1 commit into
mainfrom
feat/dcg-darwin-x64-support-07v94zdovar5u

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Naved Merchant. View the task or mention @roomote for follow-up asks.

Related GitHub Issue

Closes: #N/A — internal request (DCG macOS x86_64 support gap)

Description

Adds Destructive Command Guard (DCG) support for macOS on Intel (x86_64). Previously getDcgArchiveInfo("darwin", "x64") returned undefined, so DCG was treated as an unsupported platform on Intel Macs and command guarding could not run there.

The change uses the existing DCG_ARCHIVES platform-mapping construct in src/services/destructive-command-guard/constants.ts:

  • New darwin-x64 entry pointing at the upstream dcg-x86_64-apple-darwin.tar.xz asset from the pinned v0.7.7 release, with its SHA-256 checksum (15b42fbbbeab47123899e6328d90cd593e14999f3d275f71294815ad8ed9479c). The checksum was verified against the actual downloaded release archive.
  • No logic changes: manager.ts resolves DCG_ARCHIVES[${platform}-${arch}], so darwin/x64 now resolves automatically through the existing download, checksum-verification, and extraction path.
  • Updated the platform-mapping test in __tests__/manager.spec.ts to include darwin-x64 and assert the archive name mapping.

Test Procedure

  • Updated src/services/destructive-command-guard/__tests__/manager.spec.ts platform-mapping test now covers darwin-x64 (getDcgArchiveInfo("darwin", "x64")dcg-x86_64-apple-darwin.tar.xz).
  • vitest run services/destructive-command-guard/__tests__/manager.spec.ts: 17 passed, 1 skipped.
  • Full pnpm test (turbo, all 10 packages): all tasks successful.
  • eslint --max-warnings=0 clean on changed files; pre-commit lint-staged + full turbo lint passed.
  • The SHA-256 in the new entry was verified by downloading dcg-x86_64-apple-darwin.tar.xz from the pinned v0.7.7 GitHub release and running shasum -a 256.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Visual Snapshot (UI changes only): Not applicable — no UI change.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable — no user-visible UI change.

Videos (interaction / animation only)

Not applicable.

Documentation Updates

  • No documentation updates are required. The docs repository does not currently document DCG platform support, so there is nothing to update in Zoo-Code-Docs.
  • Yes, documentation updates are required.

Additional Notes

None.

Get in Touch

Available via @roomote mentions on this PR for follow-up questions.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@navedmerchant
navedmerchant marked this pull request as ready for review August 9, 2026 22:06
@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 9, 2026
@edelauna
edelauna added this pull request to the merge queue Aug 9, 2026
Merged via the queue into main with commit b8f70bf Aug 9, 2026
24 checks passed
@edelauna
edelauna deleted the feat/dcg-darwin-x64-support-07v94zdovar5u branch August 9, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants