Repository navigation
Fix A2A chat view a11y issues with heading level and main landmark - #223
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several HTML elements in the Angular templates to adjust heading levels and structural tags, such as replacing a <main> tag with a <div> and updating various heading elements (<h2>, <h3>, and <span>). The feedback recommends resetting the default browser margins on the newly introduced <h3> element in message-inspector.ng.html to prevent potential layout regressions.
dustinwhuang
marked this pull request as ready for review
September 22, 2026 01:30
jgindin
approved these changes
Sep 22, 2026
Contributor
⚡ A2UI Composer PR PreviewYour automated preview is successfully live (commit
|
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maintodivto avoid main landmark containment issue.Pre-launch Checklist