Skip to content

Fix A2A chat view a11y issues with heading level and main landmark - #223

Merged
jgindin merged 1 commit into
a2ui-project:mainfrom
dustinwhuang:a11y
Sep 22, 2026
Merged

jgindin merged 1 commit into
a2ui-project:mainfrom
dustinwhuang:a11y

Conversation

@dustinwhuang

Copy link
Copy Markdown
Contributor

Description

  • Adjust heading levels.
  • Change main to div to avoid main landmark containment issue.

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.
  • If my branch is on fork, I have verified that scripts/e2e_test.sh passes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several HTML elements in the Angular templates to adjust heading levels and structural tags, such as replacing a <main> tag with a <div> and updating various heading elements (<h2>, <h3>, and <span>). The feedback recommends resetting the default browser margins on the newly introduced <h3> element in message-inspector.ng.html to prevent potential layout regressions.

@dustinwhuang
dustinwhuang marked this pull request as ready for review September 22, 2026 01:30
@github-actions

Copy link
Copy Markdown
Contributor

⚡ A2UI Composer PR Preview

Your automated preview is successfully live (commit 942f9bd):
👉 Launch PR Preview

Note: This environment will be wiped automatically when the PR is merged or closed.

@jgindin
jgindin merged commit 9ba27b0 into a2ui-project:main Sep 22, 2026
12 of 13 checks passed
@dustinwhuang
dustinwhuang deleted the a11y branch October 7, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants