Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates the MCP catalog sample by removing the standalone ng-basic-with-mcp-catalog workspace and integrating its MCP capabilities directly into the standard ng-basic-catalog sample. It also enhances the shell's settings view to support editing and testing MCP server connections, moving the MCP catalog support check into McpClientManagerService. Feedback on these changes highlights a few key improvements in McpClientManagerService: first, update the servers signal before disconnecting in updateServerUrl to avoid UI flickering; second, add a guard clause to prevent unnecessary reconnections when the URL is unchanged; and third, wrap the client closing logic in a finally block within testServer to prevent potential connection leaks.
wrenj
added a commit
that referenced
this pull request
Sep 24, 2026
- Return early in updateServerUrl when the trimmed URL matches the existing server URL. - Update the servers signal and persist changes before awaiting disconnectServer in updateServerUrl to prevent UI flicker. - Ensure client.close() is invoked inside a finally block in testServer to prevent leaked connections if listTools throws.
wrenj
added a commit
that referenced
this pull request
Sep 24, 2026
- Return early in updateServerUrl when the trimmed URL matches the existing server URL. - Update the servers signal and persist changes before awaiting disconnectServer in updateServerUrl to prevent UI flicker. - Ensure client.close() is invoked inside a finally block in testServer to prevent leaked connections if listTools throws.
Contributor
⚡ A2UI Composer PR PreviewYour automated preview is successfully live (commit
|
jgindin
approved these changes
Sep 24, 2026
- Fold BasicWithMcpCatalog and MCP function schemas into samples/ng-basic-catalog and remove the duplicate samples/ng-basic-with-mcp-catalog workspace. - Restore README.md section structure under Starting the A2UI Composer. - Move doesCatalogSupportMcp from catalog-storage.model.ts into McpClientManagerService. - Pin zod dependency version to 4.6.5 without a caret prefix in bridge/package.json. - Replace the oversized Add Server button in Settings with a compact add_circle icon button, add inline URL editing, and add a Test connection button.
- Return early in updateServerUrl when the trimmed URL matches the existing server URL. - Update the servers signal and persist changes before awaiting disconnectServer in updateServerUrl to prevent UI flicker. - Ensure client.close() is invoked inside a finally block in testServer to prevent leaked connections if listTools throws.
Use the gemini-flash-latest model alias instead of a pinned version in Standalone3pLlmClient and update the corresponding unit test assertion.
- Add McpServerDialogComponent matching the Renderer and API Key dialogs - Support optional custom display names in addServer and updateServerUrl - Replace inline URL inputs in Settings with a header add button and clean empty state - Update SettingsHarness and unit tests to cover dialog workflows
…-detect - Remove Name input field from McpServerDialogComponent - Always resolve MCP server display name from serverInfo.name on connection with URL fallback - Update unit tests to match the URL-only dialog form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the post-merge review comments on #219:
Fold
ng-basic-with-mcp-catalogintong-basic-catalog& clean upREADME.mdBasicWithMcpCatalogand its MCP function entries (listMcpApps,displayMcpApp) intosamples/ng-basic-catalog(src/basic-catalog.tsandcatalog.json) and deleted the duplicatesamples/ng-basic-with-mcp-catalogworkspace.### Angular Basic with MCP Rendererheader fromREADME.mdso the### Starting the A2UI Composersteps remain contiguous.Move
doesCatalogSupportMcptoMcpClientManagerServicedoesCatalogSupportMcpout ofcatalog-storage.model.tsintoMcpClientManagerService(shell/src/app/mcp/mcp-client-manager.service.ts) and updatedChatServiceand unit tests accordingly.Pin
zodversion inbridge/package.json"zod": "4.6.5"(removing the^range prefix) inbridge/package.jsonand updatedyarn.lock.Settings MCP Servers UI improvements
Add Serverflat button with a compactmat-icon-buttonusing<mat-icon aria-hidden="true">add_circle</mat-icon>alongside theMCP Serversheader.edit,check,closeactions) for existing MCP server URLs backed byMcpClientManagerService.updateServerUrl.Testbutton (mat-stroked-button) on each server entry to test connectivity on demand viaMcpClientManagerService.testServer.