DOC-367: Update quickstart JSBins - #1166
Merged
m-hulbert merged 4 commits intoAug 6, 2021
Merged
Conversation
marklewin
approved these changes
Aug 6, 2021
Contributor
There was a problem hiding this comment.
@m-hulbert and I discussed the desirability of moving away from JQuery in all JS Bin code (DOC-367), but in the meantime this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the existing JSBins for the quickstart to modern JavaScript. It also adds a new JSBin for closing a connection to Ably. See JIRA for further information.
Note: I have raised this JIRA to look at removing JQuery from JSBin as a future improvement.
Review
The quickstart should be checked to ensure the new JSBins are correctly linked.
The new JSBins can be checked from that page or individually using: