Skip to content

Updated the spec so that it reflects the behaviour implemented in ably-cocoa - #181

Open
maratal wants to merge 1 commit into
mainfrom
PCD2-RSH3g2a-never-nil-fix
Open

Updated the spec so that it reflects the behaviour implemented in ably-cocoa#181
maratal wants to merge 1 commit into
mainfrom
PCD2-RSH3g2a-never-nil-fix

Conversation

@maratal

@maratal maratal commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Updated the spec so that it reflects the behaviour implemented in ably/ably-cocoa#1847, where a new device ID is generated as soon as the previous ones are cleared, so that id is never null.

Originally posted by @lawrence-forooghian here

Closes #180

Comment thread textile/features.textile Outdated
**** @(RSH3g1a)@ Transitions to @WaitingForDeregistration@.
*** @(RSH3g2)@ On event @Deregistered@:
**** @(RSH3g2a)@ Clears all local @DeviceDetails@.
**** @(RSH3g2a)@ Generates a new pair of device @id@ and @deviceSecret@ as described in "RSH3a2b":#RSH3a2b. Clears all other local @DeviceDetails@.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only partially describes the ably-cocoa behaviour, doesn't it? In ably-cocoa, id and deviceSecret generation are completely decoupled from the CalledActivate event, meaning that RSH3a2b and RSH8b would also need to be changed if we wished for the spec to describe the behaviour of ably-cocoa.

Also, same point as #182 (comment) re spec point modification.

@SimonWoolf

Copy link
Copy Markdown
Member

I'm not really familiar with the context here or the push activation state machine implemented in sdks, so going to untag myself and suggest @owenpearson instead

@SimonWoolf
SimonWoolf requested review from owenpearson and removed request for SimonWoolf February 12, 2024 20:35
@maratal
maratal force-pushed the PCD2-RSH3g2a-never-nil-fix branch from cd432e1 to e99fb27 Compare February 13, 2024 16:44
@maratal
maratal marked this pull request as draft March 21, 2024 12:21
@lawrence-forooghian

Copy link
Copy Markdown
Contributor

@maratal are you intending to update this one?

@maratal

maratal commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

@maratal are you intending to update this one?

Will take a closer look.

@maratal

maratal commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@maratal are you intending to update this one?

@lawrence-forooghian finally fixed

@maratal
maratal marked this pull request as ready for review January 12, 2026 01:03
@maratal maratal changed the title Updated the spec so that it reflects the behaviour implemented in ably-cocoa PR #1847 Updated the spec so that it reflects the behaviour implemented in ably-cocoa May 17, 2026
@owenpearson
owenpearson removed their request for review June 24, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

DeviceDetails.id (PCD2) should be nullable.

3 participants