Use agpl-generic-additional-terms in SugarCRM AGPL notice rules - #5278
Open
MGpromax wants to merge 1 commit into
Open
Use agpl-generic-additional-terms in SugarCRM AGPL notice rules#5278MGpromax wants to merge 1 commit into
MGpromax wants to merge 1 commit into
Conversation
The two agpl-3.0_and_other-copyleft rules match the SugarCRM Tidbit license notice, which adds extra permissions and terms under sections 7(a) and 7(b) of the AGPL-3.0. These are exactly the kind of one-off AGPL section 7 terms that the agpl-generic-additional-terms license exception is meant to capture, so use agpl-3.0 WITH agpl-generic-additional-terms instead of agpl-3.0 AND other-copyleft, consistent with the existing agpl-3.0_with_agpl-generic-additional-terms rules. The rule files are renamed to match their new license expression. Reference: aboutcode-org#5274 Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
MGpromax
force-pushed
the
fix-agpl-additional-terms-rules
branch
from
August 24, 2026 08:05
fecd679 to
84dc7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5274
The
agpl-3.0_and_other-copyleft_1.RULEtext is the SugarCRM Tidbit license notice, which adds extra permissions/terms under sections 7(a) and 7(b) of the AGPL-3.0 -- exactly what the genericagpl-generic-additional-termsentry is for, as reported in the issue.Two notes on how this is implemented:
agpl-generic-additional-termsis defined withis_exception: yes, and all 35 existing rules that use it pair it asagpl-3.0 WITH agpl-generic-additional-terms. So this PR usesWITHrather than theANDsuggested in the issue, for consistency with the existingagpl-3.0_with_agpl-generic-additional-terms_*rules. Happy to switch toANDif you prefer.agpl-3.0_and_other-copyleft_2.RULEis the same SugarCRM notice text (it only differs by an https vs http gnu.org URL), so it gets the same treatment.Both rule files are renamed (
agpl-3.0_with_agpl-generic-additional-terms_36/37.RULE) to match their new license expression.Validation:
scancode-reindex-licensesruns cleanagpl-3.0 WITH agpl-generic-additional-termswith score 100pytest tests/licensedcode/test_license_models.pypasses locallytests/)Tasks