Skip to content

Use agpl-generic-additional-terms in SugarCRM AGPL notice rules - #5278

Open
MGpromax wants to merge 1 commit into
aboutcode-org:developfrom
MGpromax:fix-agpl-additional-terms-rules
Open

Use agpl-generic-additional-terms in SugarCRM AGPL notice rules#5278
MGpromax wants to merge 1 commit into
aboutcode-org:developfrom
MGpromax:fix-agpl-additional-terms-rules

Conversation

@MGpromax

Copy link
Copy Markdown

Fixes #5274

The agpl-3.0_and_other-copyleft_1.RULE text is the SugarCRM Tidbit license notice, which adds extra permissions/terms under sections 7(a) and 7(b) of the AGPL-3.0 -- exactly what the generic agpl-generic-additional-terms entry is for, as reported in the issue.

Two notes on how this is implemented:

  • agpl-generic-additional-terms is defined with is_exception: yes, and all 35 existing rules that use it pair it as agpl-3.0 WITH agpl-generic-additional-terms. So this PR uses WITH rather than the AND suggested in the issue, for consistency with the existing agpl-3.0_with_agpl-generic-additional-terms_* rules. Happy to switch to AND if you prefer.
  • agpl-3.0_and_other-copyleft_2.RULE is the same SugarCRM notice text (it only differs by an https vs http gnu.org URL), so it gets the same treatment.

Both rule files are renamed (agpl-3.0_with_agpl-generic-additional-terms_36/37.RULE) to match their new license expression.

Validation:

  • scancode-reindex-licenses runs clean
  • scanning the SugarCRM notice text now detects agpl-3.0 WITH agpl-generic-additional-terms with score 100
  • pytest tests/licensedcode/test_license_models.py passes locally
  • no test fixtures reference the old rule identifiers or the old expression (checked with grep over tests/)

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable) -- not applicable
  • Updated CHANGELOG.rst (if applicable) -- not applicable

The two agpl-3.0_and_other-copyleft rules match the SugarCRM Tidbit
license notice, which adds extra permissions and terms under sections
7(a) and 7(b) of the AGPL-3.0. These are exactly the kind of one-off
AGPL section 7 terms that the agpl-generic-additional-terms license
exception is meant to capture, so use
agpl-3.0 WITH agpl-generic-additional-terms instead of
agpl-3.0 AND other-copyleft, consistent with the existing
agpl-3.0_with_agpl-generic-additional-terms rules.

The rule files are renamed to match their new license expression.

Reference: aboutcode-org#5274
Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
@MGpromax
MGpromax force-pushed the fix-agpl-additional-terms-rules branch from fecd679 to 84dc7ad Compare August 24, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agpl-3.0_and_other-copyleft_1.RULE should use agpl-generic-additional-terms instead of other-copyleft

1 participant