Skip to content

test(sccm): correct site-core rollover contract - #347

Merged
adamgell merged 5 commits into
codex/parser-family-skeletonfrom
codex/sccm-327-canonical-contract-fix
Jul 30, 2026
Merged

adamgell merged 5 commits into
codex/parser-family-skeletonfrom
codex/sccm-327-canonical-contract-fix

Conversation

@adamgell

@adamgell adamgell commented Jul 30, 2026 •

Copy link
Copy Markdown
Owner

Refs #327.

Corrects the committed site-core preparation corpus to the documented ConfigMgr rollover and fail-closed coverage contracts.

Scope

  • canonicalizes sitecomp.log rollover to sitecomp.lo_, including the fixture, manifest, expected request, and full provenance
  • validates all 18 corpus artifacts: 14 physical captured/capped artifacts have safe in-root paths, existing files, and exact bytes
  • enforces nonphysical absent/accessDenied/skipped/unsupported/parseFailed semantics without inventing files, bytes, or complete fragments
  • rejects capped artifacts that claim complete fragments
  • rejects missing, misspelled, or unknown capture states
  • remains preparation-only with no production reducer or native Windows acceptance claim

TDD corrections

Focused red→green slices covered canonical rollover identity, capped completeness, all-artifact storage integrity, nonphysical states, and missing/unknown state fail-closed behavior. Independent and CodeRabbit reviews drove the latter corpus-wide checks.

Verification at 4d31e981cfab061e786b1bfba02bd4260a9750f0

  • restacked onto current shared base 6ef2482d; all 5 issue-scoped commits map =
  • focused site-core — 5/5
  • exact corpus validator — 9 scenarios, 18 artifacts, 14 physical, 5 nonphysical state types
  • full parser — 620/620 (351 unit + 222 ESP + 1 client intake + 1 server intake + 5 site-core + 40 SCCM)
  • strict parser Clippy — pass
  • wasm32 parser check — pass
  • npx tsc --noEmit — pass
  • owned rustfmt and git diff --check — pass

Issue #327 remains open for production implementation and native validation.

Copilot AI review requested due to automatic review settings July 30, 2026 20:54
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@adamgell, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5cc96f0a-84bb-4770-84d6-88f2d9e1b051

📥 Commits

Reviewing files that changed from the base of the PR and between 84a784c and 4d31e98.

📒 Files selected for processing (4)
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/evidence/sccm/server/site-core/sitecomp/lo_/sitecomp.lo_
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/expected.json
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/manifest.json
  • crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs
📝 Walkthrough

Walkthrough

The rotation-boundary SCCM site-core fixture now consistently uses sitecomp.lo_. A new Rust contract test validates scenario manifests, artifact coverage rules, topology, storage metadata, and rotation-boundary file details.

Changes

SCCM site-core fixture validation

Layer / File(s) Summary
Canonical rotation-boundary fixture
crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/...
Updates fixture evidence, manifest paths, original basename, and expected requested basename to sitecomp.lo_.
Site-core fixture contract tests
crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs
Adds manifest enumeration, coverage and artifact-storage contract helpers, topology and rotation-boundary assertions, and targeted unit tests for physical, capped, and nonphysical artifacts.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing the SCCM site-core rollover contract and related test fixtures.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@adamgell adamgell self-assigned this Jul 30, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

Please review exact head ff45cd1c08541f3d38cc05f92510aaf796666bfa. Rate-limit or skipped status is not being treated as approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Your plan includes PR reviews subject to rate limits. More reviews will be available in 1 minute.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the SCCM site-core test corpus and its contract checks with ConfigMgr’s documented rollover grammar by treating sitecomp.log rollovers as sitecomp.lo_ (not sitecomp.log.lo_). It also adds a focused, cross-platform contract test to ensure the committed fixtures remain internally consistent (paths, bytes copied, and requested-artifact basenames).

Changes:

  • Added a new sccm_site_core_fixture_contract test that validates scenario matrix invariants (site code format, coverage/fragment semantics, canonical .lo_ rollover basename, resolvable paths, and exact bytes).
  • Updated the rotation-boundary site-core fixture manifest and expected output to use the canonical sitecomp.lo_ rollover basename/path.
  • Added/renamed the committed rollover fixture file to match the updated manifest path and basename.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs New contract test for site-core fixtures (site code, coverage semantics, canonical rollover basename/path, bytes, and requested-artifact basenames).
crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/manifest.json Corrects rollover artifact originalBasename and relativePath to sitecomp.lo_.
crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/expected.json Updates requested-artifact basenames to request sitecomp.lo_ and forbid sitecomp.log.lo_.
crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/evidence/sccm/server/site-core/sitecomp/lo_/sitecomp.lo_ Adds/renames the .lo_ rollover fixture file to match the corrected contract paths.

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Review exact head 02bd3727a6be42e3625e3239d268941087cd3d9b, including the new capped-fragment negative test and the canonical rollover correction. A skipped or rate-limited response is not approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='02bd3727a6be42e3625e3239d268941087cd3d9b'
git cat-file -e "${head}^{commit}"
printf '%s\n' '== HEAD =='
git show -s --format='%H%nParents: %P%nSubject: %s' "$head"

base="$(git merge-base "$head" origin/main 2>/dev/null || git merge-base "$head" main)"
printf '%s\n' "== MERGE BASE: $base =="
printf '%s\n' '== DIFF STAT =='
git diff --stat "$base" "$head"
printf '%s\n' '== CHANGED FILES =='
git diff --name-status "$base" "$head"

printf '%s\n' '== OUTLINES FOR CHANGED SOURCE FILES =='
git diff --name-only "$base" "$head" | while IFS= read -r f; do
  case "$f" in
    *.rs|*.py)
      echo "--- $f"
      ast-grep outline "$f" --items all || true
      ;;
  esac
done

Length of output: 35453


🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='02bd3727a6be42e3625e3239d268941087cd3d9b'
parent="$(git rev-parse "${head}^")"

printf '%s\n' '== INCREMENTAL PATCH =='
git diff --find-renames --find-copies --no-ext-diff "$parent" "$head" -- \
  crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core \
  crates/cmtraceopen-parser/tests/sccm_spine_contract.rs \
  crates/cmtraceopen-parser/src/sccm/catalog.rs

printf '%s\n' '== SITE-CORE FIXTURE CONTRACT TEST =='
cat -n crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs

printf '%s\n' '== CATALOG SITE COMPONENT ENTRIES AND NAME PARSING =='
sed -n '100,190p' crates/cmtraceopen-parser/src/sccm/catalog.rs
sed -n '401,535p' crates/cmtraceopen-parser/src/sccm/catalog.rs

printf '%s\n' '== ROTATION GRAMMAR TESTS =='
sed -n '249,430p' crates/cmtraceopen-parser/tests/sccm_spine_contract.rs

printf '%s\n' '== SITE-CORE MANIFEST STATIC CONSISTENCY =='
python3 - <<'PY'
import hashlib
import json
from pathlib import Path

root = Path("crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core")
errors = []
for manifest_path in sorted(root.glob("*/manifest.json")):
    doc = json.loads(manifest_path.read_text())
    for i, artifact in enumerate(doc.get("artifacts", [])):
        evidence = artifact.get("evidence")
        if evidence is not None:
            path = manifest_path.parent / evidence
            if not path.is_file():
                errors.append(f"{manifest_path}: artifacts[{i}] missing evidence {evidence}")
        requested = artifact.get("requestedArtifact", "")
        if requested.endswith(".log.lo_") and "sitecomp" in requested.lower():
            errors.append(f"{manifest_path}: artifacts[{i}] forbidden sitecomp rollover {requested}")
        if "sitecomp.log.lo_" in str(artifact):
            errors.append(f"{manifest_path}: artifacts[{i}] contains forbidden sitecomp.log.lo_")
print("manifests:", len(list(root.glob("*/manifest.json"))))
print("errors:", len(errors))
print("\n".join(errors))
PY

printf '%s\n' '== RELEVANT FIXTURE FILES (PATH, SIZE, SHA-256) =='
find crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core \
  -type f \( -name 'manifest.json' -o -name 'sitecomp.log' -o -name 'sitecomp.lo_' \) \
  -print0 | sort -z | xargs -0 sha256sum

Length of output: 25837


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== ROTATION-BOUNDARY MANIFEST AND EXPECTED OUTPUT =='
cat -n crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/manifest.json
cat -n crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/expected.json

printf '%s\n' '== CAPPED/INCOMPLETE SITE-CORE MANIFESTS =='
for f in \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/incomplete/manifest.json \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/malformed/manifest.json; do
  echo "--- $f"
  cat -n "$f"
done

printf '%s\n' '== DOCUMENTED COVERAGE AND ROTATION CONTRACT EXCERPTS =='
rg -n -i -C 4 'fragmentComplete|captureState|capped|sitecomp\.lo_|sitecomp\.log\.lo_' \
  docs/sccm/preparation/issue-327-server-site-core-corpus.md \
  docs/superpowers/plans/2026-07-30-sccm-server-intake-and-core.md

printf '%s\n' '== COMPLETE SITE-CORE STATIC INVARIANTS =='
python3 - <<'PY'
import json
from collections import Counter, defaultdict
from pathlib import Path

root = Path("crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core")
counts = Counter()
complete_by_state = defaultdict(list)
errors = []
for manifest_path in sorted(root.glob("*/manifest.json")):
    doc = json.loads(manifest_path.read_text(encoding="utf-8"))
    scenario = manifest_path.parent.name
    artifacts = doc.get("artifacts", [])
    for n, artifact in enumerate(artifacts):
        state = artifact.get("captureState", "<missing>")
        rotation = artifact.get("rotation", {})
        complete = rotation.get("fragmentComplete", "<missing>")
        counts[state] += 1
        if complete is True:
            complete_by_state[state].append(f"{scenario}[{n}]")
        rel = artifact.get("relativePath")
        if rel is not None and not (manifest_path.parent / rel).is_file():
            errors.append(f"{scenario}[{n}]: unresolvable relativePath {rel!r}")
        if state == "captured" and rel is not None:
            declared = artifact.get("bytesCopied")
            actual = (manifest_path.parent / rel).stat().st_size
            if declared != actual:
                errors.append(f"{scenario}[{n}]: bytesCopied={declared!r}, actual={actual}")
print("captureState counts:", dict(sorted(counts.items())))
print("complete fragments by state:", dict(sorted(complete_by_state.items())))
print("errors:", errors)

rotation_manifest = root / "rotation-boundary" / "manifest.json"
rotation = json.loads(rotation_manifest.read_text())
rollovers = [a for a in rotation["artifacts"] if a.get("rotation", {}).get("kind") == "loUnderscore"]
print("lo_ artifacts:", [(a.get("originalBasename"), a.get("relativePath"), a.get("bytesCopied")) for a in rollovers])
PY

printf '%s\n' '== ALL SITE-COMP ROLLOVER REFERENCES =='
rg -n -i -C 2 'sitecomp(\.log)?\.lo_' \
  crates/cmtraceopen-parser/tests \
  docs/sccm/preparation/issue-327-server-site-core-corpus.md

Length of output: 38294


@adamgell Reviewed exact head 02bd3727a6be42e3625e3239d268941087cd3d9b.

No actionable findings in the capped-fragment negative test or canonical site-core rollover correction. The corpus consistently uses sitecomp.lo_ in the manifest, fixture path, and requested-artifact contract; static validation also found resolvable evidence paths and matching captured byte counts. This is a completed review, not an approval.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adamgell
adamgell force-pushed the codex/sccm-327-canonical-contract-fix branch from 02bd372 to cb3e153 Compare July 30, 2026 21:12

Copy link
Copy Markdown
Owner Author

Rebased cleanly onto byte-stable parser-family base 99554f4aef0c06b2ce81eaf257c76058c38c06c0; new exact head is cb3e153143b7e86db0e19b46f54855c59443cb42.

Fresh post-rebase verification: focused site-core 2/2; exact-byte corpus validator PASS; full parser 596/596; strict Clippy; wasm32; npx tsc --noEmit; owned rustfmt; git diff --check — all green.

All reviews attached to the pre-rebase SHA are stale by design. Fresh independent exact-head review is pending/active.

@coderabbitai review

Review exact head cb3e153143b7e86db0e19b46f54855c59443cb42 against base 99554f4aef0c06b2ce81eaf257c76058c38c06c0. Do not carry forward the pre-rebase result, and do not infer native Windows acceptance. A skipped/rate-limited response is not approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='99554f4aef0c06b2ce81eaf257c76058c38c06c0'
head='cb3e153143b7e86db0e19b46f54855c59443cb42'

git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
git merge-base --is-ancestor "$base" "$head"

printf '%s\n' '== REQUESTED RANGE =='
git show -s --format='base: %H%nparents: %P%nsubject: %s' "$base"
git show -s --format='head: %H%nparents: %P%nsubject: %s' "$head"

printf '%s\n' '== CHANGED FILES =='
git diff --find-renames --find-copies --name-status "$base" "$head"
printf '%s\n' '== DIFF STAT =='
git diff --stat "$base" "$head"
printf '%s\n' '== COMPLETE PATCH =='
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"

printf '%s\n' '== CHANGED RUST OUTLINES =='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
  case "$path" in
    *.rs)
      printf '%s\n' "--- $path"
      ast-grep outline "$path" --items all
      ;;
  esac
done

printf '%s\n' '== SITE-CORE CONTRACT TEST =='
contract_path="$(fd -t f '^sccm_site_core_fixture_contract\.rs$' crates)"
test -n "$contract_path"
cat -n "$contract_path"

printf '%s\n' '== CHANGED FIXTURE JSON =='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
  case "$path" in
    *.json)
      printf '%s\n' "--- $path"
      cat -n "$path"
      ;;
  esac
done

Length of output: 24575


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== CANDIDATE DOCUMENTATION AND PARSER FILES =='
fd -t f . docs crates | rg '(^|/)(issue-327-server-site-core-corpus|2026-07-30-sccm-server-intake-and-core|catalog|sccm_spine_contract)\.(md|rs)$' || true

printf '%s\n' '== DOCUMENTED COVERAGE / ROTATION CONTRACT =='
rg -n -i -C 5 'fragmentComplete|captureState|capped|accessDenied|unsupported|sitecomp\.lo_|sitecomp\.log\.lo_|loUnderscore' \
  docs crates/cmtraceopen-parser/tests/sccm_spine_contract.rs \
  crates/cmtraceopen-parser/src/sccm/catalog.rs || true

printf '%s\n' '== PARSER ROTATION GRAMMAR CONTEXT =='
catalog_path="$(fd -t f '^catalog\.rs$' crates/cmtraceopen-parser/src)"
if test -n "$catalog_path"; then
  rg -n -i -C 8 'loUnderscore|\.lo_|rotation|basename|sitecomp' "$catalog_path"
fi

printf '%s\n' '== WHOLE SITE-CORE CORPUS STATIC AUDIT =='
python3 - <<'PY'
import json
from pathlib import Path

root = Path("crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core")
errors = []
summary = []
for manifest_path in sorted(root.glob("*/manifest.json")):
    scenario = manifest_path.parent.name
    document = json.loads(manifest_path.read_text(encoding="utf-8"))
    artifacts = document.get("artifacts")
    if not isinstance(artifacts, list):
        errors.append(f"{scenario}: artifacts is not an array")
        continue
    for index, artifact in enumerate(artifacts):
        ident = f"{scenario}.artifacts[{index}]"
        state = artifact.get("captureState")
        rotation = artifact.get("rotation", {})
        complete = rotation.get("fragmentComplete")
        basename = artifact.get("originalBasename")
        relative = artifact.get("relativePath")
        if state in {"absent", "accessDenied", "capped", "skipped", "unsupported"} and complete is True:
            errors.append(f"{ident}: {state} complete fragment")
        if state == "captured":
            if not isinstance(relative, str):
                errors.append(f"{ident}: captured artifact lacks relativePath")
            else:
                fixture = manifest_path.parent / relative
                if not fixture.is_file():
                    errors.append(f"{ident}: missing {relative}")
                elif artifact.get("bytesCopied") != fixture.stat().st_size:
                    errors.append(f"{ident}: bytesCopied={artifact.get('bytesCopied')} actual={fixture.stat().st_size}")
        if rotation.get("kind") == "loUnderscore":
            if not isinstance(basename, str) or not basename.endswith(".lo_") or basename.endswith(".log.lo_"):
                errors.append(f"{ident}: noncanonical loUnderscore basename={basename!r}")
            if not isinstance(relative, str) or not relative.endswith(f"/{basename}"):
                errors.append(f"{ident}: path/basename mismatch relativePath={relative!r} basename={basename!r}")
        summary.append((scenario, artifact.get("artifactId"), state, rotation.get("kind"), complete))
print("manifests:", len(list(root.glob('*/manifest.json'))))
print("artifacts:", len(summary))
print("artifact tuples:")
for item in summary:
    print("  ", item)
print("errors:", len(errors))
for error in errors:
    print("  ERROR", error)

expected_path = root / "rotation-boundary" / "expected.json"
expected = json.loads(expected_path.read_text(encoding="utf-8"))
basenames = expected["unlinkedObservations"][0]["nextArtifacts"][0]["basenames"]
print("rotation-boundary requested basenames:", basenames)
PY

printf '%s\n' '== ALL CURRENT SITE-COMP ROLLOVER REFERENCES =='
rg -n -i -C 2 'sitecomp(\.log)?\.lo_|sitecomp\.lo_' \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core \
  crates/cmtraceopen-parser/tests \
  docs/sccm/preparation || true

Length of output: 168677


@adamgell Fresh independent review completed for exact range 99554f4aef0c06b2ce81eaf257c76058c38c06c0..cb3e153143b7e86db0e19b46f54855c59443cb42.

Finding: sccm_site_core_fixture_contract.rs only checks relativePath resolution and bytesCopied against the file size for the single rotation-boundary .lo_ artifact (Lines 108–128). The manifest loop at Lines 54–78 does not validate these properties for the other captured/capped artifacts, despite the corpus contract requiring local evidence and exact byte provenance for all of them. A later broken path or stale byte count in any other scenario would therefore pass this test.

Please extend the per-artifact loop to validate that every captured or capped artifact has a resolvable relativePath and that bytesCopied equals the fixture’s actual byte length.

The canonical sitecomp.lo_ correction itself is consistent with the parser’s .lo_ grammar, the fixture path, manifest, and requested-artifact contract. Static auditing of the current corpus found no path or byte-count discrepancies. This review does not infer native Windows acceptance.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Owner Author

Substantive post-rebase CodeRabbit gate: local CodeRabbit CLI 0.7.1 reviewed the exact committed range from codex/parser-family-skeleton (99554f4) through cb3e153143b7e86db0e19b46f54855c59443cb42. Result: review_completed, 0 findings, all 4 changed files reviewed (canonical sitecomp.lo_ fixture, manifest, expected contract, and Rust guard). This exact-head result supersedes the pre-rebase review; fresh independent review remains active.

@adamgell adamgell left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head review: BLOCKED at cb3e153143b7e86db0e19b46f54855c59443cb42 (base 99554f4aef0c06b2ce81eaf257c76058c38c06c0).

Actionable finding

crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs enumerates all nine manifests at lines 54–78, but that loop only applies the fragmentComplete: true coverage check. File resolution and bytesCopied equality are checked only for the single rotation-boundary .lo_ artifact at lines 108–128. The corpus has 14 physical captured/capped artifacts, so a missing path or stale byte count in any of the other 13 artifacts would still pass the committed Rust contract test. The exact-byte Python validator used during preparation is not tracked in this PR/repository and therefore is not a durable CI guard.

Please move/add the path and exact-byte validation to the per-artifact loop for every captured and capped artifact, with a focused red mutation/probe and green rerun. Preserve the current capped-fragment negative probe. While touching that loop, retain the documented nonphysical-state boundary (absent, accessDenied, skipped, unsupported, parseFailed: no physical path and zero copied bytes).

What is already correct

  • Canonical sitecomp.lo_ rename, manifest basename/path, and bounded requested basename are consistent.
  • All 9 scenarios, 18 artifacts, and 46 manifest/expected/evidence references currently audit clean; site code is synthetic LAB; findings remain role-local and conservative; no live/native acceptance is claimed.
  • #345 is merged and the rebased base supplies crates/cmtraceopen-parser/tests/fixtures/** -text; a controlled core.autocrlf=true checkout remains byte-identical at 196 bytes.
  • CodeRabbit completed a substantive review of this exact range and independently reported the same all-artifact path/byte guard gap; this is not a skipped/rate-limited result.

Verification on the exact head: focused 2/2; exact-byte corpus validator PASS; full parser 596/596; strict Clippy PASS; wasm32 PASS; npx tsc --noEmit PASS; owned-file rustfmt PASS; git diff --check PASS. cargo fmt --check --all remains nonzero only on unchanged pre-existing files outside this PR; the changed Rust file is not among its diffs.

Review scope remains synthetic fixture/test preparation only. Issue #327 must stay open for the production reducer and eventual native Windows validation.

@adamgell
adamgell force-pushed the codex/sccm-327-canonical-contract-fix branch from cb3e153 to 9235f81 Compare July 30, 2026 21:19

Copy link
Copy Markdown
Owner Author

Independent review 4823290589 disposition: fixed test-first at new exact head 84a784c8f69f0cae12a7f02f4289516fabc443dd.

  • RED: focused storage-contract test failed to compile before the per-artifact validator existed.
  • GREEN: every one of the 14 captured/capped artifacts across all 9 scenarios now has a safe relative path, an existing physical fixture, and exact bytesCopied validation.
  • Negative probes reject missing files, wrong sizes, unsafe parent paths, and missing byte provenance.
  • absent, accessDenied, skipped, unsupported, and parseFailed are all tested as nonphysical: null/no path, zero bytes, and no complete-fragment claim.
  • The capped-fragment negative probe and canonical sitecomp.lo_ assertions remain.

Fresh focused 4/4, exact-byte validator, full parser 598/598, strict Clippy, wasm32, TypeScript, owned rustfmt, and diff checks are green. (The aggregate count increased by two focused regressions.)

@coderabbitai review

Please review exact head 84a784c8f69f0cae12a7f02f4289516fabc443dd; do not carry forward the prior cb3e153 result. A skipped/rate-limited response is not approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

@adamgell Fresh review requested for exact head 84a784c8f69f0cae12a7f02f4289516fabc443dd. I will assess this head independently and will not treat any skipped or rate-limited result as approval.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs (1)

48-116: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Unrecognized captureState values silently pass validation.

artifact_storage_failures only branches on "captured" | "capped" and the five non-physical states; any other/typoed captureState value falls through both branches and returns no failures — and is also excluded from the physical_artifacts tally in the calling test. A typo in a fixture manifest (e.g. wrong casing) would silently bypass path/byte validation instead of failing loudly.

♻️ Proposed fix: fail closed on unrecognized states
     } else if matches!(
         state,
         "absent" | "accessDenied" | "skipped" | "unsupported" | "parseFailed"
     ) {
         if !artifact["relativePath"].is_null() {
             failures.push(format!(
                 "{state} artifact {artifact_id} cannot have a relativePath"
             ));
         }
         if artifact["bytesCopied"].as_u64() != Some(0) {
             failures.push(format!(
                 "{state} artifact {artifact_id} must record zero bytesCopied"
             ));
         }
+    } else {
+        failures.push(format!(
+            "artifact {artifact_id} has unrecognized captureState {state:?}"
+        ));
     }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs` around
lines 48 - 116, Update artifact_storage_failures to explicitly reject any
captureState outside the recognized captured/capped and
absent/accessDenied/skipped/unsupported/parseFailed values, adding a failure for
the unknown state and artifact ID. Ensure the calling physical_artifacts tally
also handles unknown states consistently so unrecognized values cannot bypass
validation or be silently excluded.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs`:
- Around line 48-116: Update artifact_storage_failures to explicitly reject any
captureState outside the recognized captured/capped and
absent/accessDenied/skipped/unsupported/parseFailed values, adding a failure for
the unknown state and artifact ID. Ensure the calling physical_artifacts tally
also handles unknown states consistently so unrecognized values cannot bypass
validation or be silently excluded.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fe805779-03f8-4b32-b01d-f29baef690d1

📥 Commits

Reviewing files that changed from the base of the PR and between 02bd372 and 84a784c.

📒 Files selected for processing (4)
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/evidence/sccm/server/site-core/sitecomp/lo_/sitecomp.lo_
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/expected.json
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/manifest.json
  • crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/evidence/sccm/server/site-core/sitecomp/lo_/sitecomp.lo_

@adamgell adamgell left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head re-review: BLOCKED at 84a784c8f69f0cae12a7f02f4289516fabc443dd (base 690cb32240a86001fdc4c3acc58e63638814d20e).

The prior all-artifact blocker is fixed: all 14 captured/capped artifacts now traverse the safe-relative-path, existing-file, and exact-bytesCopied checks, and the missing/wrong/unsafe/missing-byte probes exercise those paths.

Remaining actionable finding

artifact_storage_failures handles the two physical states and five declared nonphysical states, but any missing, misspelled, or unrecognized captureState falls through and returns no failure. Changing an existing nonphysical state such as accessDenied to a typo leaves physical_artifacts == 14, so the main test also continues to pass while path/byte/fragment validation is silently bypassed. CodeRabbit’s substantive exact-head review independently reported this at review 4823345266; it was not a skipped or rate-limited result.

Please fail closed for every state outside captured, capped, absent, accessDenied, skipped, unsupported, and parseFailed, and add a focused unknown/missing-state negative probe. The calling test then cannot silently admit an unversioned coverage state.

Verified on this exact head

  • Focused site-core contract: 4/4 PASS.
  • Exact corpus validator: PASS.
  • Full parser suite: 598/598 PASS.
  • Strict Clippy, wasm32 check, npx tsc --noEmit, owned-file rustfmt, and git diff --check: PASS.
  • Independent corpus audit: 9 scenarios, 18 artifacts, 14 physical artifacts, 46 evidence/coverage references, zero inconsistencies.
  • Canonical sitecomp.lo_, synthetic LAB topology, privacy boundaries, conservative role-local claims, and no-native-acceptance boundary remain correct.
  • Local CodeRabbit CLI 0.7.1 was authenticated but rate-limited for 41 minutes; that invocation was not counted as approval. GitHub CodeRabbit did complete the substantive review cited above.

cargo fmt --check --all remains nonzero only on unchanged pre-existing files outside this PR; the changed Rust test is clean under rustfmt 1.88. Issue #327 remains open for production reducer/native validation work.

Copy link
Copy Markdown
Owner Author

CodeRabbit review 4823345266 / independent review 4823350276 disposition: fixed at exact head fcfcd29f518d1c9bc5e706f1c2417cabe1a71263.

TDD red reproduced both missing and misspelled captureState silently returning zero validation failures. The storage contract now fails closed for every state outside the seven allowed site-core values and asserts the exact 18-artifact/14-physical matrix. Dedicated probes cover missing and caputred states.

Focused 5/5, exact-byte corpus validator, full parser 599/599, strict Clippy, wasm32, TypeScript, owned rustfmt, and diff checks pass.

@coderabbitai review

Review exact head fcfcd29f518d1c9bc5e706f1c2417cabe1a71263; do not carry forward prior results. A skipped/rate-limited response is not approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='fcfcd29f518d1c9bc5e706f1c2417cabe1a71263'
git cat-file -e "${head}^{commit}"
parent="$(git rev-parse "${head}^")"

printf '%s\n' '== REQUESTED HEAD =='
git show -s --format='%H%nParents: %P%nSubject: %s' "$head"
printf '%s\n' '== INCREMENTAL CHANGED FILES =='
git diff --find-renames --find-copies --name-status "$parent" "$head"
printf '%s\n' '== INCREMENTAL PATCH =='
git diff --find-renames --find-copies --no-ext-diff "$parent" "$head"

contract="$(fd -t f '^sccm_site_core_fixture_contract\.rs$' crates)"
test -n "$contract"
printf '%s\n' '== CONTRACT TEST OUTLINE =='
ast-grep outline "$contract" --items all
printf '%s\n' '== CONTRACT TEST =='
cat -n "$contract"

printf '%s\n' '== SITE-CORE MANIFEST SUMMARY / STATIC STORAGE AUDIT =='
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path, PurePosixPath

root = Path("crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core")
allowed = {"captured", "capped", "absent", "accessDenied", "skipped", "unsupported", "parseFailed"}
physical = {"captured", "capped"}
errors = []
counts = Counter()
physical_count = 0
for manifest_path in sorted(root.glob("*/manifest.json")):
    doc = json.loads(manifest_path.read_text(encoding="utf-8"))
    for index, artifact in enumerate(doc.get("artifacts", [])):
        ident = f"{manifest_path.parent.name}.artifacts[{index}]"
        state = artifact.get("captureState")
        counts[state] += 1
        rel = artifact.get("relativePath")
        bytes_copied = artifact.get("bytesCopied")
        complete = artifact.get("rotation", {}).get("fragmentComplete")
        if state not in allowed:
            errors.append(f"{ident}: invalid state {state!r}")
            continue
        if state in physical:
            physical_count += 1
            if not isinstance(rel, str) or not rel:
                errors.append(f"{ident}: physical artifact lacks path")
            else:
                posix = PurePosixPath(rel)
                if posix.is_absolute() or ".." in posix.parts:
                    errors.append(f"{ident}: unsafe path {rel!r}")
                fixture = manifest_path.parent / rel
                if not fixture.is_file():
                    errors.append(f"{ident}: fixture missing {rel!r}")
                elif bytes_copied != fixture.stat().st_size:
                    errors.append(f"{ident}: declared={bytes_copied!r}, actual={fixture.stat().st_size}")
        else:
            if rel is not None or bytes_copied != 0 or complete is True:
                errors.append(f"{ident}: nonphysical path={rel!r}, bytes={bytes_copied!r}, complete={complete!r}")
print("manifests:", len(list(root.glob("*/manifest.json"))))
print("artifacts:", sum(counts.values()))
print("physical:", physical_count)
print("states:", dict(sorted(counts.items(), key=lambda x: str(x[0]))))
print("errors:", len(errors))
for error in errors:
    print("ERROR:", error)
PY

printf '%s\n' '== CURRENT SITE-CORE ROLLOVER REFERENCES =='
rg -n -i -C 2 'sitecomp(\.log)?\.lo_|sitecomp\.lo_' \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core \
  crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs

Length of output: 25149


@adamgell Reviewed exact head fcfcd29f518d1c9bc5e706f1c2417cabe1a71263 independently.

No actionable findings. The storage validator now fails closed for a missing or unrecognized captureState, and the dedicated probes cover both missing state and caputred. The contract also asserts the current 18-artifact / 14-physical-artifact matrix.

A separate static audit of all nine site-core manifests found no unsafe paths, missing fixtures, byte-count discrepancies, or invalid nonphysical storage claims. The canonical sitecomp.lo_ contract remains consistent across manifest, fixture path, and expected request output.

This is a completed review, not an approval; I did not execute the test suite in the sandbox.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adamgell adamgell left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head review: PASS at fcfcd29f518d1c9bc5e706f1c2417cabe1a71263 against base 690cb32240a86001fdc4c3acc58e63638814d20e. No actionable findings.

Blocker disposition

  • Missing and misspelled captureState values now fail closed, with dedicated missing-state and caputred probes.
  • The committed matrix pins 18 artifacts and 14 physical artifacts. Every captured/capped artifact receives safe-relative-path, existing-file, and exact-bytesCopied validation.
  • The four nonphysical artifacts currently present are valid; dedicated probes cover all five declared nonphysical state types (absent, accessDenied, skipped, unsupported, parseFailed) for no physical path, zero bytes, and no complete-fragment claim.
  • Missing file, wrong size, parent traversal, missing byte provenance, and capped-complete-fragment probes remain effective.

Contract and boundary verification

  • Nine scenarios, 18 artifacts, 14 physical artifacts, and 46 manifest/expected/evidence references audit clean.
  • Canonical sitecomp.lo_ is consistent across the physical fixture, manifest basename/path, and bounded expected request; byte-sensitive fixture attributes remain text: unset.
  • Site code/topology remains synthetic LAB / LAB-CM01; privacy scans found no live identifiers or credentials.
  • Findings remain conservative and role-local with explicit prohibited client-impact, absent-role, and cross-side-causality claims.
  • The diff is fixture/test-only: no parser-kind duplication, Windows I/O, registry/WMI/Tauri/network/database dependency, production reducer, or native Windows acceptance claim.

Fresh verification

  • cargo test --locked -p cmtraceopen-parser --test sccm_site_core_fixture_contract: 5/5 PASS.
  • Exact-byte corpus validator: PASS.
  • cargo test --locked -p cmtraceopen-parser --quiet: 599/599 PASS.
  • Strict Clippy: PASS.
  • wasm32 check: PASS.
  • npx tsc --noEmit: PASS.
  • Rustfmt 1.88 on the changed Rust file: PASS.
  • git diff --check: PASS; detached review worktree remained clean.

CodeRabbit exact-head comment 5136448138 reported no actionable findings after examining the incremental fix plus the full contract/static corpus. It explicitly did not execute tests and CodeRabbit is incremental, so it was not treated as approval; this PASS is based on the independent full-range inspection and fresh verification above.

This approves the preparation/test slice only. Issue #327 should remain open for the production reducer and eventual native Windows validation.

@adamgell
adamgell force-pushed the codex/sccm-327-canonical-contract-fix branch from fcfcd29 to 4d31e98 Compare July 30, 2026 21:48
@adamgell

Copy link
Copy Markdown
Owner Author

Current-base refresh: PR #347 is restacked without patch drift onto merged shared interface 6ef2482d20e132e9ca7db920a9e1199e2f8bd7ea; new exact head 4d31e981cfab061e786b1bfba02bd4260a9750f0. All 5 issue-scoped commits map = in range-diff.

Fresh gates: focused 5/5; exact 9-scenario/18-artifact validator (14 physical plus all 5 nonphysical state types); full parser 620/620; strict Clippy; wasm32; TypeScript; owned rustfmt; diff check — all green.

@coderabbitai review

Review exact head 4d31e981cfab061e786b1bfba02bd4260a9750f0 against exact base 6ef2482d20e132e9ca7db920a9e1199e2f8bd7ea. Confirm missing/unknown capture states fail closed and the full storage/coverage matrix remains sound. Older-SHA results are stale; skipped, incremental-only, or rate-limited is not approval.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='6ef2482d20e132e9ca7db920a9e1199e2f8bd7ea'
head='4d31e981cfab061e786b1bfba02bd4260a9750f0'

git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
git merge-base --is-ancestor "$base" "$head"

printf '%s\n' '== REQUESTED RANGE =='
git show -s --format='base: %H%nparents: %P%nsubject: %s' "$base"
git show -s --format='head: %H%nparents: %P%nsubject: %s' "$head"
printf '%s\n' '== RANGE-DIFF / COMMITS =='
git log --oneline --decorate "${base}..${head}"
printf '%s\n' '== CHANGED FILES =='
git diff --find-renames --find-copies --name-status "$base" "$head"
printf '%s\n' '== DIFF STAT =='
git diff --stat "$base" "$head"
printf '%s\n' '== COMPLETE PATCH =='
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"

contract="$(fd -t f '^sccm_site_core_fixture_contract\.rs$' crates)"
test -n "$contract"
printf '%s\n' '== CONTRACT TEST OUTLINE =='
ast-grep outline "$contract" --items all
printf '%s\n' '== CONTRACT TEST =='
cat -n "$contract"

printf '%s\n' '== FIXTURE MANIFESTS =='
fd -t f '^manifest\.json$' crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core \
  -x sh -c 'echo "--- $1"; cat -n "$1"' sh {}

printf '%s\n' '== STATIC STORAGE / COVERAGE / ROTATION AUDIT =='
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path, PurePosixPath

root = Path("crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core")
allowed = {"captured", "capped", "absent", "accessDenied", "skipped", "unsupported", "parseFailed"}
physical = {"captured", "capped"}
errors = []
states = Counter()
manifests = sorted(root.glob("*/manifest.json"))

for manifest_path in manifests:
    scenario = manifest_path.parent.name
    doc = json.loads(manifest_path.read_text(encoding="utf-8"))
    artifacts = doc.get("artifacts")
    if not isinstance(artifacts, list):
        errors.append(f"{scenario}: artifacts is not an array")
        continue
    for index, artifact in enumerate(artifacts):
        ident = f"{scenario}.artifacts[{index}]"
        state = artifact.get("captureState")
        states[state] += 1
        rel = artifact.get("relativePath")
        copied = artifact.get("bytesCopied")
        rotation = artifact.get("rotation")
        complete = rotation.get("fragmentComplete") if isinstance(rotation, dict) else None
        if state not in allowed:
            errors.append(f"{ident}: invalid captureState={state!r}")
            continue
        if state in physical:
            if not isinstance(rel, str) or not rel:
                errors.append(f"{ident}: physical artifact has invalid path={rel!r}")
            else:
                path = PurePosixPath(rel)
                if path.is_absolute() or ".." in path.parts:
                    errors.append(f"{ident}: unsafe path={rel!r}")
                fixture = manifest_path.parent / rel
                if not fixture.is_file():
                    errors.append(f"{ident}: missing fixture={rel!r}")
                elif copied != fixture.stat().st_size:
                    errors.append(f"{ident}: bytesCopied={copied!r}, actual={fixture.stat().st_size}")
        elif rel is not None or copied != 0 or complete is True:
            errors.append(f"{ident}: nonphysical path={rel!r}, bytes={copied!r}, complete={complete!r}")
        if isinstance(rotation, dict) and rotation.get("kind") == "loUnderscore":
            basename = artifact.get("originalBasename")
            if not isinstance(basename, str) or not basename.endswith(".lo_") or basename.endswith(".log.lo_"):
                errors.append(f"{ident}: invalid lo_ basename={basename!r}")
            elif not isinstance(rel, str) or not rel.endswith("/" + basename):
                errors.append(f"{ident}: lo_ path/basename mismatch path={rel!r}, basename={basename!r}")

print("manifest_count:", len(manifests))
print("artifact_count:", sum(states.values()))
print("physical_count:", sum(states[s] for s in physical))
print("states:", dict(sorted(states.items(), key=lambda item: str(item[0]))))
print("errors:", len(errors))
for error in errors:
    print("ERROR:", error)
PY

printf '%s\n' '== ROLLOVER REFERENCES AND TEST PROBES =='
rg -n -i -C 3 \
  'sitecomp(\.log)?\.lo_|sitecomp\.lo_|captureState|caputred|missing.*state|unknown.*state' \
  crates/cmtraceopen-parser/tests/sccm_site_core_fixture_contract.rs \
  crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core

Length of output: 83034


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== PARSER ROTATION GRAMMAR =='
catalog="$(fd -t f '^catalog\.rs$' crates/cmtraceopen-parser/src)"
test -n "$catalog"
rg -n -i -C 8 'loUnderscore|\.lo_|sitecomp|rotation' "$catalog"

printf '%s\n' '== EXISTING SCCM INTEGRATION TEST LAYOUT =='
fd -t f '\.rs$' crates/cmtraceopen-parser/tests \
  | sort \
  | sed -n '1,220p'

printf '%s\n' '== PACKAGE TEST TARGET CONFIGURATION =='
cargo_toml="$(fd -t f '^Cargo\.toml$' crates/cmtraceopen-parser)"
test -n "$cargo_toml"
cat -n "$cargo_toml"

printf '%s\n' '== EXACT ROTATION-BOUNDARY EXPECTED CONTRACT =='
cat -n crates/cmtraceopen-parser/tests/fixtures/sccm/server/site_core/rotation-boundary/expected.json

printf '%s\n' '== CURRENT HEAD DIFF CHECK =='
git diff --check 6ef2482d20e132e9ca7db920a9e1199e2f8bd7ea 4d31e981cfab061e786b1bfba02bd4260a9750f0

Length of output: 14760


@adamgell Reviewed exact range 6ef2482d20e132e9ca7db920a9e1199e2f8bd7ea..4d31e981cfab061e786b1bfba02bd4260a9750f0 independently.

No actionable findings.

  • Missing and unknown captureState values fail closed: artifact_storage_failures accepts only the seven explicit states and emits a failure for all others, with dedicated probes for absent and misspelled values.
  • Every artifact in the nine-scenario corpus is passed through the coverage and storage validators. The contract pins 18 artifacts and 14 physical (captured/capped) artifacts.
  • Physical artifacts require safe relative paths, an existing fixture, and exact bytesCopied; nonphysical states require no path and zero bytes. The independent static audit found zero violations.
  • The canonical rollover correction is consistent: parser grammar maps .lo_ to LoUnderscore, and the fixture filename, manifest path/basename, and expected request use sitecomp.lo_.
  • git diff --check was clean.

This is a completed static review, not an approval. I did not execute the test suite in the sandbox and do not infer native Windows acceptance.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adamgell
adamgell merged commit de5eca6 into codex/parser-family-skeleton Jul 30, 2026
1 check passed
adamgell added a commit that referenced this pull request Aug 4, 2026
Part of #327. Canonicalize sitecomp.lo_ and enforce fail-closed site-core artifact storage, coverage, capped-fragment, and capture-state contracts. No production reducer or native acceptance.
@adamgell
adamgell deleted the codex/sccm-327-canonical-contract-fix branch September 25, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants