Repository navigation
fix(parser): reject Unicode decimal fields - #502
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe parser now uses ASCII-only digit matching, handles malformed UTF-8 label lengths without invalid slicing, and adds regression tests for Unicode numeric fields, DNS labels, reporting events, and Intune tracking. ChangesUnicode input hardening
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/cmtraceopen-parser/tests/issue_413_unicode_panics.rs`:
- Around line 18-29: Update the tests in
crates/cmtraceopen-parser/tests/issue_413_unicode_panics.rs at lines 18-29 to
retain the no-panic parser calls while inspecting their results and asserting
that malformed Unicode decimal fields do not produce the affected parsed
records; also update lines 52-60 to inspect returned events and assert that
Unicode inventory counts do not produce an inventory event.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 997daa25-db2e-4a54-935d-c82bfabeed7a
📒 Files selected for processing (7)
crates/cmtraceopen-parser/src/intune/event_tracker.rscrates/cmtraceopen-parser/src/parser/ccm.rscrates/cmtraceopen-parser/src/parser/dns_types.rscrates/cmtraceopen-parser/src/parser/reporting_events.rscrates/cmtraceopen-parser/src/parser/simple.rscrates/cmtraceopen-parser/src/parser/timestamped.rscrates/cmtraceopen-parser/tests/issue_413_unicode_panics.rs
|
Independent critic verdict at Blocking omission: The existing CCM/simple/timestamped/reporting/DNS/event-tracker fixes otherwise passed the class audit. Rework is assigned to:
|
|
Independent critic re-review: ACCEPT at frozen SHA
Residual risk is limited to that already-filed legacy signless-tail behavior, outside #413. Hosted CI is the remaining gate. |
|
Final integration critic: ACCEPT at frozen merge SHA
Residual integration risk is low. Restarted hosted CI is the final merge gate. |
Summary
Verification
cargo test --test issue_413_unicode_panicscargo test -p cmtraceopen-parsercargo clippy -p cmtraceopen-parser --all-targets -- -D warningsrustfmt --checkon changed Rust filesCloses #413
Summary by CodeRabbit
Bug Fixes
Tests