Repository navigation
Conversation
Pure derivations for spec 8.10: KPIs with derivable sublabels only, channel bars, top event IDs with the hide-rule qualifier, the hour by channel matrix and hourly errors and warnings with the peak. Events without a timestamp are counted as unplaced, never placed in hour 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Token-styled KPI grid and 2x2 figures per spec 8.10, taking plain data so wiring is one line. Heat-map empty cells have a defined outline token, tested against the faintest heat step in all seven themes. Heat map and hourly figures carry visually hidden data tables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and debounce (#846) Unplaced events follow the engine's parsed_timestamp_epoch rule, text-log lines stay out of event ID and channel derivations, the loaded channel and text log counts come from the caller, the chains qualifier shows for any partial edge set, figure 3 discloses the channel cap, off-order channel colors no longer depend on visibility, and chart data is debounced at 75 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Errors and warnings per hour is drawn by the Fluent chart through public props, with a fixed-height host and host CSS for the two things the props do not cover in 9.3.27. The spike record is rewritten to match what was observed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds the Charts entry to the workspace view map with React.lazy, fed by the visible records, the chain model built from the first timeline page, the quick filter as hide rule, the channel list and the analysis log item count. Adds the Charts view capture to the Event Logs screenshot spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…licate import (#846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 4275f54. Main's ruling: spec 8.10 falls back to token-styled markup when the chart needs overrides beyond public props. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oncrete spike record (#846) Rewrites the library spike record with the 9.3.27 evidence, labels the hourly axis HH:00 every six hours, names the workspace chain model for Phase 10c, and updates the rehydration test now that Charts is a real view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd (#846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…arity (#846) The Warnings share divides by every warning on the tile, figures 1 and 3 disclose the text-log lines they leave out (and figure 3's unplaced note counts events only), placement accepts the space separator chrono accepts, and the spike record drops the hex-only clause. Adds window, text-log source and loaded channel helpers, and tests that fail under a UTC-only local hour and under the text-log guards being removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nnels and window (#846) Adds a pure channel-order helper that matches the channel pane (checked against the real pane), and feeds the Charts view the distinct text-log sources, the per-mode loaded channel count and the window label, with workspace tests for each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w element capture (#846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd docs (#846) Files mode counts distinct event-record channels (an archived text log is not a channel, shared names count once, empty files add none), figure 4's unplaced note counts errors and warnings, hour 24 stays unplaced and the U+2212 minus sign is accepted as chrono does, and the prop docs and spike record are corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…head (#846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ity, gated counts (#846) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… of restarting (#846) A restarting debounce never fired under a stream faster than 75 ms, so the charts showed stale counts during a busy live tail. The wait now starts at the first change and fires no later than 75 ms after it. The spec 11 deviation is recorded at the constant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
4 of 34 tasks
… the data (#846) The throttled chart data and the live `loading` prop changed in different renders, so a load that ended with rows said "No events to chart" for up to 75 ms before the figures drew. The same split let the window label ("7 d") and the clock in the figure qualifiers ("hour of day, UTC") change over counts and buckets of the previous window and clock. The throttle now carries one memoized snapshot of the input, `loading` and `windowLabel`, and the view reads all three from the settled value, so the copy and the data change in the same render. The cost is accepted: a load that ends with zero rows says "Loading events..." for up to 75 ms before "No events to chart". Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nge (#846) The first F1 tests rebuilt every prop on each rerender, so a change to the input memo or the snapshot memo dependencies was masked by the other props changing too. Flip only `loading`, only `windowLabel` and only `timeZoneMode` against a shared base so a missing memo dependency fails. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…Date.parse (#846) Only the hour and the day were range-checked, so an out-of-range minute, second or offset reached Date.parse and was accepted or rejected by whatever the engine does. The RFC 3339 and zone-less patterns now allow minute and second 00 to 59 and an offset of +HH:MM or -HH:MM with HH 00 to 23 and MM 00 to 59, so no field's range is left to Date.parse. Second 60 stays unplaced on every engine, the declared narrowing. The negative tests replace Date.parse with a parser that accepts anything and assert it is never called, so they fail on a lenient engine, not only on the one the suite runs in. Boundary tests keep minute 59, second 59 and offsets up to 23:59 placed with the real parser. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… JavaScript does (#846) The engine calls Rust's `str::trim` before parsing, which strips the Unicode White_Space set. String.prototype.trim differs in two code points: it strips U+FEFF, which Rust keeps, and keeps U+0085, which Rust strips. So a timestamp with an edge U+FEFF was placed in an hour the engine leaves unplaced, and one with an edge U+0085 was unplaced where the engine places it. The text is now trimmed over the Rust set, spelled out as escapes (checked against rustc's char::is_whitespace over every code point: no mismatch). Tests cover all 25 Rust code points on both sides, U+FEFF on either edge (unplaced), and code points neither engine trims. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
chrono accepts any number of fraction digits and truncates to milliseconds. The ES date-time format has exactly three, so a one-digit or six-digit fraction was the last field whose handling was left to the engine. The fraction is now cut or padded to three digits before parsing, which also truncates instead of rounding, as the engine does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…its wait (#846) The stream test only checked when the figures updated, not what they showed. It now asserts each update shows the count at that moment and the last wait applies the final count and leaves no timer. A new test covers unmount: the pending wait is cleared and a remount shows the current value at once. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The chart data throttles from the first change instead of restarting a debounce. Two comments still called it debounced. The doc comment on CHART_DATA_THROTTLE_MS keeps the word, because it records the deliberate deviation from spec 11's debounce wording. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #846. Part of #823. Stacked on #929 (Phase 3): review the commits after its merge base; this PR retargets to main when #929 merges.
What it adds
The Charts tab of the Event Logs view bar now draws a chart view instead of the Phase 3 placeholder. It loads lazily, so the chart code stays out of the initial bundle.
aria-label. The heat map and the hourly figure each carry a visually hidden data table.Main modules:
src/workspaces/event-log/evtx-chart-data.ts: pure derivations (tile values, channel bars, top IDs, hour by channel matrix, hourly counts, peak, unplaced counts). No React, no colors, no stores.src/workspaces/event-log/EvtxChartsView.tsx: the view and its figures, default export forReact.lazy.src/workspaces/event-log/evtx-channel-order.ts: channel names in the channel pane's display order, so a channel gets the same color index in the pane and in the figures.src/workspaces/event-log/EventLogWorkspace.tsx: onelazyimport, the view-map entry forcharts, and the inputs the view needs.e2e/screenshots/event-logs.spec.ts: an "event-logs charts view" capture.Evidence rules
The claims the view makes, and the rule behind each:
str::trimtrims it (U+FEFF is kept, U+0085 is stripped), parses the way the engine parses it (parsed_timestamp_epochinsrc-tauri/src/event_log/timeline.rs): RFC 3339 with "T", "t" or a space between date and time and a U+2212 minus sign accepted in the offset only, or a zone-lessTISO form read as UTC. Every field is range-checked beforeDate.parsesees the text, so no field's range is left to the browser engine: the day must exist in its month, hour is 00 to 23, minute and second are 00 to 59, and an offset is +HH:MM or -HH:MM with HH 00 to 23 and MM 00 to 59; the fraction is cut or padded to three digits. Second 60 stays unplaced on every engine, because JavaScript cannot represent it. Display text is never guessed at. Everything else is counted as unplaced and the figure says so.loadedChannels), not every enumerated channel. Files mode counts the distinct channel names of the loaded event records: an archived text log is not a channel, a channel in several files counts once, and a file with no records adds nothing. Text logs are counted as distinct sources (file paths of attached entries plus source labels of archived text records), not as lines.EvtxChartsView.tsxwith@fluentui/react-charts9.3.27:HeatMapChartinterpolates a continuous d3 scale instead of drawing six fixed steps and has no cell gap, radius, cell size or empty-cell props.VerticalStackedBarChartwas built and captured through public props and still needed overrides outside them: itsheightis ignored, itsstylesclass names are not applied to the axes, its Y axis cannot be hidden, and it sorted numeric-looking x values wrongly. Figures 1 and 2 are token-styled rows. Spec 8.10 names "token-styled SVG" as the fallback; the code uses HTML and CSS markup.evtx-channel-order.tswas added without changingChannelPicker.tsx. It copies the pane's ordering logic; its test renders the real pane and compares, so a drift in either shows up. Phase 8 (Event Logs UI phase 8: Channel pane restyle #837) adopts it.CHART_DATA_THROTTLE_MS.Scope
11 files changed against #929: 9 source files (
EventLogWorkspace.tsx,EventLogWorkspace.layout.test.tsx,EvtxChartsView.tsxand its test,evtx-channel-order.tsand its test,evtx-chart-data.tsand its test,e2e/screenshots/event-logs.spec.ts) plus 2 PNGs. That is over the 5-file limit, so the CLAUDE.md issue-lane exception applies. The issue lists 4 files; the added files are the channel order helper (the capture criterion on the issue and the channel color rule in spec 6.3), the workspace wiring, and the e2e capture the issue comments require. No Rust, store, package or token files change.Known limits
Review findings that are out of this lane's scope, or recorded rather than fixed:
chartChannelOrderstill includes archived text-log labels ({archive}::{member}) in files mode. Per the 2026-10-11 coordination note on Event Logs UI phase 14: Charts view #846, whichever of Event Logs UI phase 14: Charts view #846 and Event Logs UI phase 8: Channel pane restyle #837 lands second excludes them from the order input and switches the order test's row selector todata-channel-row.loadedChannelCountForandcountTextLogSourcesalso exist in the Status bar lane (Event Logs UI phase 15: Event Logs status bar content and toolbar action #847,evtx-status-summary.ts), and both lanes editEventLogWorkspace.tsx. The second of Event Logs UI phase 14: Charts view #846 and Event Logs UI phase 15: Event Logs status bar content and toolbar action #847 to merge removes the duplicates.loadedChannels.sizefrom the distinct record channels (both are 1), so only the unit test guards live mode.Reviews
Five review rounds on this lane: round 1 at
097e02ab(10 findings), verification 1 atee610a87(10), verification 2 atc0a905fb(4), verification 3 atd4ca3df4(3, all low), and the final verification atec99786d(4 low, 2 nits). The final verification found verification 3's two classes still open: the first in one place (the load-state copy changed up to 75 ms before its data), the second in two (minute, second and offset ranges reachedDate.parse; JavaScript's trim removed U+FEFF, which the engine keeps). They are fixed in478dce29(load state, window label and clock settle with the data),d332b466(every field range-checked) andd1b09f12(edge whitespace trimmed as the engine trims it), with7904e5b3pinning each throttled field,642b942d(a three-digit fraction),1df5b46c(the throttle applies the latest value and clears its wait) and4e5430d1(comments say throttled). Verification at4e5430d1closed all six findings at the class level and found only two body sentences to correct, corrected here.Verification
At head
4e5430d1ca1857a70df53290f81978195f83598f:npx tsc --noEmit: exit 0.npx vitest run --maxWorkers=3: exit 0, 175 test files, 2960 tests passed, no "Unhandled Errors". Each of the 7 fix commits was also checked out alone: tsc and the event-log tests pass at every one.git diff a0b70cd6 --check: exit 0. No U+2013 or U+2014 in added lines. No real account name or machine identifier in added lines.npx playwright test -c playwright.screenshots.config.ts --list: exit 0, 11 tests in 2 files, including "event-logs charts view". Screenshot and e2e runs were not executed locally (port 1420 is shared across lanes).src-tauriis untouched, so no Rust gates apply.Screenshots
Two captures are new in this PR:
screenshots/event-logs-charts.png(the page at 1440 x 900) andscreenshots/event-logs-charts-view.png(the full Charts view element, grown to its content). No existing PNG changes. PNGs are regenerated in Main's capture session before merge.🤖 Generated with Claude Code