Skip to content

fix(build): fork builds publish to the latest update feed #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adampeterhiggins merged 1 commit into from
Oct 19, 2026
Merged

fix(build): fork builds publish to the latest update feed #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions scripts/build-desktop-artifact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
owner: "pingdotgg",
repo: "t3code",
releaseType: "release",
channel: "latest",
});
assert.deepStrictEqual(nightlyConfig, {
provider: "github",
Expand Down Expand Up @@ -371,6 +372,7 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
owner: "pingdotgg",
repo: "t3code",
releaseType: "release",
channel: "latest",
},
]);
}).pipe(
Expand All @@ -382,6 +384,24 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
),
);

it.effect("publishes fork builds to the latest feed", () =>
Effect.gen(function* () {
const config = yield* createBuildConfig(
"mac",
"zip",
"0.1.0-fork.20261019.1",
false,
true,
3000,
undefined,
);

assert.deepStrictEqual(config.publish, [
{ provider: "generic", url: "http://localhost:3000", channel: "latest" },
]);
}).pipe(Effect.provide(ConfigProvider.layer(ConfigProvider.fromEnv({ env: {} })))),
);

it("stages only the desktop main-process externals", () => {
assert.deepStrictEqual(
resolveDesktopRuntimeDependencies(
Expand Down
5 changes: 4 additions & 1 deletion scripts/build-desktop-artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,7 +2620,9 @@ export const resolveGitHubPublishConfig = Effect.fn("resolveGitHubPublishConfig"
owner,
repo,
releaseType: updateChannel === "nightly" ? "prerelease" : "release",
...(updateChannel === "nightly" ? { channel: "nightly" as const } : {}),
// Left unset, electron-builder names the feed after the prerelease identifier, so a `-fork.`
// build would write `fork-mac.yml` while the app reads `latest-mac.yml`.
channel: updateChannel,
};
});

Expand Down Expand Up @@ -2736,6 +2738,7 @@ export const createBuildConfig = Effect.fn("createBuildConfig")(function* (
{
provider: "generic",
url: resolveMockUpdateServerUrl(mockUpdateServerPort),
channel: updateChannel,
},
];
}
Expand Down