Skip to content

fix(kafka): preserve broker Service during pending removal - #318

Merged
amuraru merged 1 commit into
adobe:masterfrom
amuraru:fix/broker-service-pending-removal
Aug 19, 2026
Merged

fix(kafka): preserve broker Service during pending removal#318
amuraru merged 1 commit into
adobe:masterfrom
amuraru:fix/broker-service-pending-removal

Conversation

@amuraru

@amuraru amuraru commented Aug 19, 2026

Copy link
Copy Markdown

Summary

  • defer headless/non-headless Service cleanup while a running broker pod is outside spec.brokers
  • add focused unit coverage for the outside-spec running broker guard
  • update broker-scaling e2e paths to patch spec.brokers directly instead of applying independent manifests with unrelated drift
  • add the KRaft broker upscale/downscale e2e path using addKafkaClusterBroker/removeKafkaClusterBrokers
  • remove the universal capacity default from the KRaft sample so capacity.json actually changes during scaling
  • avoid passing namespaces to cluster-scoped CRD deletes in e2e uninstall cleanup, removing noisy kubectl warnings without changing generic delete behavior

Testing

  • go test ./pkg/resources/kafka
  • (cd tests/e2e && go test -tags=e2e . -run '^$')

@amuraru
amuraru force-pushed the fix/broker-service-pending-removal branch from 64136f8 to 62bb0a8 Compare August 19, 2026 07:57
@amuraru
amuraru force-pushed the fix/broker-service-pending-removal branch 2 times, most recently from fa35277 to ed0c133 Compare August 19, 2026 08:42
Delay headless/non-headless Service cleanup while any running broker pod is no longer listed in spec.brokers. Such pods are waiting for Cruise Control removal and are outside per-broker reconciliation, so switching addressing can delete their only Service.

Update broker-scaling e2e coverage to patch spec.brokers directly instead of applying independent manifests, avoiding unrelated spec drift during removal/upscale scenarios. Add the KRaft broker scaling path and remove the universal capacity default from the KRaft sample so capacity.json changes are actually exercised.

Avoid passing namespaces to cluster-scoped CRD deletes in e2e uninstall cleanup, removing noisy kubectl warnings without changing generic delete behavior.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@amuraru
amuraru force-pushed the fix/broker-service-pending-removal branch from ed0c133 to b336641 Compare August 19, 2026 08:52
@amuraru
amuraru merged commit 32f5006 into adobe:master Aug 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant