CraftFromContainers.BepInExPlugin+Smelter_OnAddOre_Patch.Prefix

[JakubKurs]

Hey mate,
The latest version of CraftFromContainers (v4.0.30) broke adding ore to the smelter.
When trying to add ores using Shift+E, an error appears in the console:
[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object Stack trace: CraftFromContainers.BepInExPlugin+Smelter_OnAddOre_Patch.Prefix (Smelter __instance, Humanoid user, ItemDrop+ItemData item, ZNetView ___m_nview) (at <55003e1c5df140a88accf02b3ad387aa>:0) (wrapper dynamic-method) Smelter.DMD<Smelter::OnAddOre>(Smelter,Switch,Humanoid,ItemDrop/ItemData) Switch.Interact (Humanoid character, System.Boolean hold, System.Boolean alt) (at <90663da6b3074a37975cc8a72a434494>:0) (wrapper dynamic-method) Player.DMD<Player::Interact>(Player,UnityEngine.GameObject,bool,bool) (wrapper dynamic-method) Player.DMD<Player::Update>(Player)

Actions taken:

• Server restart
• Client restart

[kometes-]

It looks like the AddOre API changed. I can't find any documentation on the change. I will relay the fix here if I find where someone else finds it. If it's not fixed in a couple weeks, I will debug it.

Workaround: In the config file, set FillAllModKey to nothing:

## Modifier key to pull all available fuel or ore when down. Use https://docs.unity3d.com/Manual/ConventionalGameInput.html
# Setting type: String
# Default value: left shift
FillAllModKey =

[JakubKurs]

Issue has been resolved in #138 .

I've checked on my own and it's working.

[kometes-]

Thank you. I confirm that it is working.

[Meeeat]

Confirming this is still broken on the Thunderstore-published builds even after the PR #138 fix was merged and confirmed here. Just hit the exact same NullReferenceException on both v4.0.30 and v4.0.40 as installed via Thunderstore Mod Manager (fresh download today, 2026-09-20), so it looks like the fix hasn't made it into a published package version yet.

Same stack trace both times:

NullReferenceException: Object reference not set to an instance of an object
Stack trace:
CraftFromContainers.BepInExPlugin+Smelter_OnAddOre_Patch.Prefix (Smelter __instance, Humanoid user, ItemDrop+ItemData item, ZNetView ___m_nview)
(wrapper dynamic-method) Smelter.DMD<Smelter::OnAddOre>(Smelter,Switch,Humanoid,ItemDrop/ItemData)
Switch.Interact (Humanoid character, System.Boolean hold, System.Boolean alt)
(wrapper dynamic-method) Player.DMD<Player::Interact>(Player,UnityEngine.GameObject,bool,bool)
(wrapper dynamic-method) Player.DMD<Player::Update>(Player)

Also worth noting: it's not just a silent failure, it actually consumes items - ore gets removed from the source stack but never makes it into the smelter, so it's a real item-loss bug, not just a missing feature.

For anyone hitting this in the meantime: downgrading to v4.0.20 works correctly (confirmed ore/fuel pulls into the smelter with no errors). Haven't tried the FillAllModKey workaround from the comment above since 4.0.20 already resolves it, but flagging that combined with this report in case it helps others avoid the item loss until a fixed version is actually published.