Repository navigation
✅ Sync eaa125400e1: [release/10.0] Fix LoadExactInterfaceMap for sub-interfaces with complex type arguments under special marker parents (#124835) - #129
Merged
Conversation
…lex type arguments under special marker parents (dotnet#124835) Backport of dotnet#124684 to release/10.0 /cc @davidwrighton ## Customer Impact - [x] Customer reported - [ ] Found internally The earlier fix for dotnet#123254 did not fix all possible cases where the incorrect type would be loaded. This fix fills out the special case matrix some more, and I believe should fix all the issues found. ## Regression - [x] Yes - [ ] No This issue was introduced with PR dotnet#120712, and mitigated somewhat with PR dotnet#123520. This fix builds on that fix to fix additional issues found by @reduckted. ## Testing The fix includes a fairly large test suite covering possible ways type loading could fail around this fix. It was missed previously in the previous small fix as the importance of comparing the fully loaded, and partially loaded interface maps on the generic type definition was missed during test development. This fix has also been tested by delivering a hotfixed build to @reduckted which which he was able to verify fixed the issues he had seen in production as well as in testing. ## Risk Low. Its filling out more special cases in the new codepaths added in PR dotnet#123520. **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. --------- Co-authored-by: David Wrighton <davidwr@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ease-10.0-eaa125400e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commit:
eaa125400e1— [release/10.0] Fix LoadExactInterfaceMap for sub-interfaces with complex type arguments under special marker parents (dotnet#124835)\nRemaining after this: 23 commit(s)\n\n---\n\n# Sync Report:release/10.0→bazelUpstream commits: 1 | Files changed: 3
Classification: ✅ clean — No Bazel-relevant build changes detected
No Bazel-relevant changes detected in the upstream diff.