-
Notifications
You must be signed in to change notification settings - Fork 15
chore: promote next to main #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,8 +86,8 @@ Dependabot labels its PRs `dependencies` only (ecosystem sub-labels were dropped | |
|
|
||
| release-please opens/updates a `chore: release main` PR on each push to `main`. | ||
|
|
||
| 1. Review the version bumps + changelog in the release PR (it is authored by the **aidd-bot** App, so its checks run normally). | ||
| 2. Merge it: `gh pr merge <n> --squash`. No admin needed - the App is a ruleset bypass actor, so its PRs merge once checks pass. | ||
| 1. (Optional) Review the version bumps + changelog. The PR is authored by the **aidd-bot** App, so its checks run normally. | ||
| 2. CI **auto-merges** it with the App token (`--squash --admin`); no human step is needed. `--admin` is required because a plain `gh pr merge` is refused even for the bypass App. | ||
| 3. CI tags each bumped package, creates the GitHub Releases, and attaches the bundles: | ||
| - `aidd-framework-marketplace-X.Y.Z.zip` (`.claude-plugin/` + `plugins/`) | ||
| - `<plugin>-vX.Y.Z.zip` | ||
|
|
@@ -109,7 +109,9 @@ Two bypass actors (both `pull_request` mode, so neither can push directly to `ma | |
|
|
||
| The App: ID in secret `AIDD_BOT_APP_ID`, key in `AIDD_BOT_PRIVATE_KEY`. If the App is broken/uninstalled, release and Dependabot PRs stop merging - fix the App rather than re-adding an admin bypass. | ||
|
|
||
| To change protection, edit `.github/rulesets/main.json`, then apply it live: | ||
| Head branches are **not** auto-deleted on merge (`delete_branch_on_merge: false`): the promote PR merges `next` into `main` without deleting `next`, so the back-merge that realigns `next` afterwards never hits a missing branch. Do not re-enable the setting. | ||
|
|
||
| To change protection, edit `.github/rulesets/main.json` (or `next.json`), then apply it live: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When the change is to Useful? React with 👍 / 👎. |
||
| ```bash | ||
| gh api -X PUT repos/ai-driven-dev/framework/rulesets/<id> --input .github/rulesets/main.json | ||
| ``` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For non-major Dependabot PRs targeting
next,.github/workflows/dependabot-auto-merge.ymlonly runsgh pr merge --auto --squash; the upstreamgh pr mergemanual says--automerges only after necessary requirements are met, while--adminis the flag for merging despite unmet requirements. With this line adding a required approval and no workflow step that approves the PR, those patch/minor dependency PRs will now wait for a human review instead of auto-merging once checks pass, so either keep Dependabot exempt/approved or use an explicit bypass path for that workflow.Useful? React with 👍 / 👎.