Repository navigation
Fix iPhone Duo having stale width in some cases - #170
Merged
Merged
Conversation
bryankeller
reviewed
Oct 13, 2026
ephraimkunz
commented
Oct 13, 2026
| _delegateMagazineLayout = currentCollectionView.delegate as? UICollectionViewDelegateMagazineLayout | ||
|
|
||
| // Save the previous collection view width and horizontal insets if necessary | ||
| if prepareActions.contains(.cachePreviousHorizontalMetrics) { |
Contributor
Author
There was a problem hiding this comment.
No need for this action any more, since we can just check it below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When rotating a magazine layout on a closed iPhone Duo, I can consistently reproduce an issue where there is a stale width for cells.
Before
Screen.Recording.2026-10-12.at.5.20.04.PM.mov
After
Screen.Recording.2026-10-12.at.5.34.06.PM.mov
Types of changes
Checklist