Skip to content

read_and_format doesn't cover all cases #8

Open

Description

@szeevs

The function is not robust.
To cover all cases you need to comply with:
https://docs.aws.amazon.com/datapipeline/latest/DeveloperGuide/dp-template-redshift.html

For example, what if you get int(8) from MySQL?

Activity

  1. benjamingregory commented on Mar 22, 2018

    @benjamingregory
    Member

    Very good point @szeevs. This was done quickly to handle a specific implementation but you're absolutely right; it needs to be more robust.

    Are you interested in taking this issue?

  2. szeevs commented on Mar 22, 2018

    @szeevs
    ContributorAuthor

    Yes. I will resolve this.

  3. benjamingregory commented on Mar 22, 2018

    @benjamingregory
    Member

    Great! Just assigned you @szeevs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions