Repository navigation
ci(macos): stage protocol-45 builds as client release 0.42.0 - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS workflow's "Build Apple Silicon Release staging app" step fails on every PR. It stages the app as Kit client release
0.39.0, whichbuild_and_run.shrejects:That guard came from dc8ea7f (
fix(protocol): align stable protocol 45 compatibility), which was committed directly tomain. The macOS workflow only runs on pull requests, so the stale pin first surfaced on #65.This updates the staging step to
0.42.0: both theKIT_MACOS_CLIENT_RELEASEenv var and theKitClientReleaseInfo.plist assertion. That matchesclient_release="0.42.0"inapps/macos/script/package_app.shand the README. No app or script changes.Testing
0.42.0passes;0.39.0fails with the error above.