Skip to content

fix(sheets): add is_column_right field to Sheet model - #484

Merged
prasad-albert merged 1 commit into
mainfrom
feat/sheets-is-column-right
May 18, 2026
Merged

fix(sheets): add is_column_right field to Sheet model#484
prasad-albert merged 1 commit into
mainfrom
feat/sheets-is-column-right

Conversation

@prasad-albert

Copy link
Copy Markdown
Collaborator

Summary

  • Adds is_column_right: bool | None (alias isColumnRight) to the Sheet model in src/albert/resources/sheets.py
  • Field was introduced by api-worksheet PR #350 — controls whether copied columns are placed to the right or left of the source column
  • Defaults to None so existing sheets without the field deserialize cleanly

Adds the isColumnRight boolean field introduced by api-worksheet PR #350.
@prasad-albert prasad-albert changed the title feat(sheets): add is_column_right field to Sheet model fix(sheets): add is_column_right field to Sheet model May 6, 2026
@claude

claude Bot commented May 6, 2026

Copy link
Copy Markdown

Code Review

Issues Found

  • PR title The title uses fix: but the change adds a new field to the model — that's a feature addition, not a bug fix. Should be feat(sheets): add is_column_right field to Sheet model.

Summary

1 issue found. Low severity — title-only; the code change itself is correct.

@prasad-albert

Copy link
Copy Markdown
Collaborator Author

Code Review

Issues Found

  • PR title The title uses fix: but the change adds a new field to the model — that's a feature addition, not a bug fix. Should be feat(sheets): add is_column_right field to Sheet model.

Summary

1 issue found. Low severity — title-only; the code change itself is correct.

@claude A field addition isn't new capability - it's correcting an incomplete model. The field already exists in the API response; the SDK was just missing it. feat is for new methods or parameters. Backfilling a missing field is fix.

@claude

claude Bot commented May 13, 2026

Copy link
Copy Markdown

Claude finished @prasad-albert's task in 21s —— View job


That's a fair point and I agree with the reasoning. The field already exists in the API response — the SDK was silently dropping it, which is an incomplete/incorrect model representation. Backfilling a missing field to match the existing API contract is correcting a defect, not introducing new capability. fix: is the right prefix here.

I'm retracting that issue. The code change is correct and the title is appropriate.


@prasad-albert
prasad-albert merged commit 75327db into main May 18, 2026
3 checks passed
@prasad-albert
prasad-albert deleted the feat/sheets-is-column-right branch May 18, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants