docs(agents): record unset-vs-empty rule for update payloads - #562
Draft
prasad-albert wants to merge 1 commit into
Draft
docs(agents): record unset-vs-empty rule for update payloads#562prasad-albert wants to merge 1 commit into
prasad-albert wants to merge 1 commit into
Conversation
Add OPINIONS.md with the PATCH/update() unset-vs-empty rule and link it from AGENTS.md so it is read before touching update methods or patch-payload generators.
|
Looks good - no bugs or correctness issues found. |
prasad-albert
marked this pull request as draft
June 26, 2026 05:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
OPINIONS.mdcapturing the non-obvious rule for PATCH/update()payloads: a field the caller never set must be left untouched, gated onmodel_fields_set(never onvalue is None). Distinguishes unset (no-op) from explicitNone(delete) and explicit[]/{}(clear).Links it from
AGENTS.mdCoding Standards so it is read before changing update methods or patch-payload generators.Docs-only. The corresponding code fix is in #561.