fix(sheets): omit referenceId so new formula columns aren't dropped - #630
Open
prasad-albert wants to merge 2 commits into
Open
fix(sheets): omit referenceId so new formula columns aren't dropped#630prasad-albert wants to merge 2 commits into
prasad-albert wants to merge 2 commits into
Conversation
Read pinned-column state from the product design instead of the app design. Pinned columns are sheet-wide so the value is identical, but the product design is where formulation columns live and is already loaded by add_formulation_columns, removing a redundant apps-grid request. The property now self-loads its grid so it resolves correctly when read on its own.
|
Code Review Issues Found
Summary |
add_formulation_columns no longer sends a computed referenceId when no starting_position is given. It now omits referenceId/position entirely so the platform applies its default placement. Sending a null or stale referenceId left the new column out of the sheet sequence, which hid it on the next refresh. A caller-supplied starting_position is still honored.
prasad-albert
changed the title
|
Looks good - no bugs or correctness issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_formulation_columnsno longer computes and sends areferenceIdwhen nostarting_positionis provided; it now omitsreferenceId/positionso the platform applies its default placement. Previously a null or stalereferenceIdleft the new column out of the sheet sequence, which hid it on the next refresh (root cause confirmed with the backend team).starting_positionis still honored as-is.Sheet.leftmost_pinned_columnnow sources pinned state from the product design instead of the app design (pinned columns are sheet-wide, so the value is identical). This removes a redundant apps-grid request; the property is now only used by_add_column's fallback.test_add_formulation,test_add_formulation_clear_updates_existing,test_add_formulation_no_clear_adds_new_column,test_crud_empty_column,test_property_reads(all pass).