Skip to content

fix(recommend): getTrendingFacets typing - #1494

Merged
shortcuts merged 3 commits into
masterfrom
fix/recommend-getTrendingFacets-typing
Dec 7, 2023
Merged

shortcuts merged 3 commits into
masterfrom
fix/recommend-getTrendingFacets-typing

Conversation

@marialungu

Copy link
Copy Markdown

The hits returned by getTrendingFacets differ (they only have faceValue, facetName and _score) from the normal hits returned by the other recommendation methods.

@marialungu
marialungu requested review from jojva and raed667 December 5, 2023 13:02
@marialungu marialungu changed the title Fix/recommend get trending facets typing fix(recommend): getTrendingFacets typing Dec 5, 2023

@raed667 raed667 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM 🥇

@jojva jojva left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shortcuts

Copy link
Copy Markdown
Member

lmk if you need help for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants