sentinel console disable login - #1004
Merged
Merged
Conversation
cdfive
reviewed
Aug 21, 2019
zhaoyuguang
commented
Aug 21, 2019
Member
|
@zhaoyuguang The CI indicates test failure. Could you please resolve it? |
cdfive
reviewed
Aug 22, 2019
cdfive
reviewed
Aug 22, 2019
zhaoyuguang
commented
Aug 22, 2019
cdfive
reviewed
Aug 22, 2019
Member
|
Could you please also execute the |
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
============================================
- Coverage 42.74% 42.68% -0.07%
+ Complexity 1475 1474 -1
============================================
Files 317 317
Lines 9280 9280
Branches 1267 1267
============================================
- Hits 3967 3961 -6
- Misses 4823 4828 +5
- Partials 490 491 +1
Continue to review full report at Codecov.
|
Collaborator
Author
Thanks for the guidance, |
Collaborator
|
@zhaoyuguang Nice work! Thanks for your contribution. I think the implement is simple and clever. |
Member
|
👍 |
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
[RIP-9] Polish Operations_Trace.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
由于部分公司自己开发了控制台,不希望被Sentinel的安全认证拦截。因此Sentinel支持定制关闭登陆功能,
application.properties auth.enabled=false即可完成 不需要登录主要改造有两点
1:AuthService的实例化类 改为使用auth.enabled变量控制那个实例初始化
2:增加接口以便与模拟登陆。
Does this pull request fix one issue?
Resolves #997
Describe how you did it
Describe how to verify it
Special notes for reviews