Support Etcd datasource - #1018
Merged
Merged
Conversation
using the LongAdder rather than AtomicInteger to Provides better performance
merge master
…perties directory
merge online
…cator to load log config
merge onlie
merge online
This reverts commit d401c2f
sczyh30
added
area/integrations
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
===========================================
- Coverage 42.72% 42.43% -0.3%
- Complexity 1473 1476 +3
===========================================
Files 317 319 +2
Lines 9280 9346 +66
Branches 1267 1274 +7
===========================================
+ Hits 3965 3966 +1
- Misses 4825 4891 +66
+ Partials 490 489 -1
Continue to review full report at Codecov.
|
sczyh30
reviewed
Aug 29, 2019
| * @author lianglin | ||
| * @since 1.7.0 | ||
| */ | ||
| @Ignore(value = "Before run this test, you need to set up your etcd server.") |
Member
There was a problem hiding this comment.
Is there any embedded etcd server for unit test?
Collaborator
Author
There was a problem hiding this comment.
there is none, the java version embedded etcd server I don't found.
Member
There was a problem hiding this comment.
Okay, I'll test this in local these days.
sczyh30
reviewed
Sep 8, 2019
| > Note: It needs to update JDK version to JDK8 | ||
|
|
||
|
|
||
| We've also provided an example: [sentinel-demo-etcd-datasource]. No newline at end of file |
Member
There was a problem hiding this comment.
We could add the expected URL for the demo :)
Member
|
Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
[RIP-65] Delete chinese period in CLITools.md file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Function expand, Add DataSource integration for etcd.
Does this pull request fix one issue?
Fixes #30
Describe how you did it
Through Jetcd Client https://mvnrepository.com/artifact/io.etcd/jetcd-core
Make sentinel enable communication with etcd server.
Using
EtcdConfig.javato integration Sentinel Config Load mechanism.So that the Etcd Connect Properties can Config by properies file rather than
hard code in Code.
Through Jetcd watcher listening mechanism to implemnt rule dynamic update function.
Describe how to verify it
run test cases and demo
Special notes for reviews
The Jetcd need to run JDK8 env.