Refactored MetricSearcher - #103
Merged
CarpenterLee merged 3 commits intoAug 29, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
============================================
- Coverage 45.98% 45.79% -0.19%
+ Complexity 557 556 -1
============================================
Files 113 114 +1
Lines 3806 3813 +7
Branches 530 531 +1
============================================
- Hits 1750 1746 -4
- Misses 1846 1856 +10
- Partials 210 211 +1
Continue to review full report at Codecov.
|
Contributor
|
about CLA check. you can set your git commit email set in your gitHub account. use 'git log' to see your commit email. |
| @@ -0,0 +1,117 @@ | |||
| package com.alibaba.csp.sentinel.node.metric; | |||
Contributor
There was a problem hiding this comment.
Please add Copyright and License here. Just copy the following:
/*
* Copyright 1999-2018 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
| @@ -142,7 +134,7 @@ public synchronized List<MetricNode> findByTimeAndResource(long beginTimeMs, lon | |||
| fileName + MetricWriter.METRIC_FILE_INDEX_SUFFIX, offsetInIndex); | |||
Contributor
There was a problem hiding this comment.
Please help me replace fileName + MetricWriter.METRIC_FILE_INDEX_SUFFIX with MetricWriter.formIndexFileName(fileName)
Contributor
Author
|
Thanks for the review! both me and the commiter signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performed extract class operation for MetricSearcher. Extracted fields: charset, maxLinesReturn. Extracted Methods: readMetricsInOneFileByEndTime, readMetricsInOneFile, readMetricsByEndTime.