Improve the checking logic of SystemRule and enhance SystemRuleManager - #1050
Merged
Conversation
…strategy - The BBR period for maxCpuUsage strategy is deprecated - Improve code of SystemRuleManager and SystemStatusListener - Add test cases Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
============================================
+ Coverage 42.64% 43.08% +0.44%
- Complexity 1472 1493 +21
============================================
Files 317 317
Lines 9286 9290 +4
Branches 1267 1268 +1
============================================
+ Hits 3960 4003 +43
+ Misses 4833 4795 -38
+ Partials 493 492 -1
Continue to review full report at Codecov.
|
Contributor
CPU usage value updates every seconds, this change means that if CPU usage exceed threshold, all the traffic in next second will be blocked? |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…strategy (alibaba#1050) - The BBR period for maxCpuUsage strategy is deprecated. Now Sentinel will just check the CPU usage value, which could avert surge of CPU usage quickly - Improve SystemRuleManager and SystemStatusListener - Add some test cases Signed-off-by: Eric Zhao <sczyh16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Improve
SystemRuleManagerand refactor the checking logic ofmaxCpuUsagestrategy in SystemRule.Does this pull request fix one issue?
NONE
Describe how you did it
SystemRuleManagerandSystemStatusListener.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE