Fix hookOnCancel handing logic in SentinelReactorSubscriber - #1089
Merged
Conversation
…scriber Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
============================================
+ Coverage 42.7% 42.78% +0.08%
- Complexity 1491 1493 +2
============================================
Files 319 319
Lines 9378 9379 +1
Branches 1279 1279
============================================
+ Hits 4005 4013 +8
+ Misses 4878 4872 -6
+ Partials 495 494 -1
Continue to review full report at Codecov.
|
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…1089) Signed-off-by: Eric Zhao <sczyh16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix the
hookOnCancelhanding logic inSentinelReactorSubscriberto avoid Entry-exit leaking.Does this pull request fix one issue?
Fixes #1084
Describe how you did it
Add
tryCompleteEntry()inhookOnCancelhook of SentinelReactorSubscriber.Note that this is only a temporary solution. We might need to improve or refactor the SentinelReactorSubscriber later to handle all events more appropriately according to the reactive stream specification.
Describe how to verify it
Run the test cases.
Special notes for reviews
NONE