provide sentinel-spring-webmvc-adapter - #1093
Closed
zhaoyuguang wants to merge 7 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
============================================
+ Coverage 42.7% 42.76% +0.05%
- Complexity 1491 1492 +1
============================================
Files 319 319
Lines 9378 9382 +4
Branches 1279 1279
============================================
+ Hits 4005 4012 +7
+ Misses 4878 4877 -1
+ Partials 495 493 -2
Continue to review full report at Codecov.
|
Member
|
Already resolved in #1104, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1074
增加
sentinel-spring-webmvc-adaptermodule主要是提供继承HandlerInterceptorAdapter的SentinelHandlerInterceptor
不建议同时加载
sentinel-web-servlet和sentinel-spring-webmvc-adapter当这种case时:
因为
sentinel-web-servlet的filter先于interceptor使用
Constants.SENTINEL_REQUEST_ATTR_WEB_SERVLET_ENABLE_KEY当用户引用
sentinel-web-servlet并加载filter时,标记此request被filter使用,在
sentinel-spring-webmvc-adapter的SentinelHandlerInterceptor判断如果存在就自动失效
sentinel-spring-webmvc-adapter