Bug fix: fix wrong log file name checking - #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
DateFileLogHandler.logFileExits()method uses a wrong log file name when checking log file exists, this will lead trying to recreate the log file at every log writing, which will cause performance problem.Does this pull request fix one issue?
Fixes #181
Describe how you did it
Use the right log file name when exists checking.
Describe how to verify it
RecordLog.info()in high concurrency;jstack pidto see the stack trace of the current process, then we will see many threads BLOCKEDat com.alibaba.csp.sentinel.log.DateFileLogHandler.publish().jstack pid, then we will not see threads BLOCKEDat com.alibaba.csp.sentinel.log.DateFileLogHandler.publish().Special notes for reviews
None.