fix HttpServerHandler body reading problem - #185
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
============================================
- Coverage 51.29% 51.14% -0.15%
+ Complexity 829 826 -3
============================================
Files 140 140
Lines 4753 4753
Branches 677 677
============================================
- Hits 2438 2431 -7
- Misses 2020 2031 +11
+ Partials 295 291 -4
Continue to review full report at Codecov.
|
Member
|
Thanks for contributing! |
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
…etty-http (alibaba#185) - Do a manual copying from unpooled direct buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
fix HttpServerHandler body reading problem.
When post data to netty-http an exception
UnsupportedOperationExceptionwill occur.Does this pull request fix one issue?
Fixes #184
Describe how you did it
Do a manual copying from unpooled direct buffer.
Describe how to verify it
curl -d "something" "http://api_provided_by_command_center"