Extract flow rule checker from FlowRule - #234
Merged
Merged
Conversation
- Extract flow rule checker from legacy `passCheck` - Remove redundant code - Refactor FlowSlot (some logic moved from FlowRuleManager) - Rename `Controller` to `TrafficShapingController` Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
force-pushed
the
enhancement/flow-checker
branch
from
November 12, 2018 03:45
7503541 to
2953adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Extract flow rule checker from
passChecklogic of legacyFlowRuleto make the checking logic more clear.Does this pull request fix one issue?
Related to #56
Describe how you did it
passChecklogic of legacyFlowRuleFlowSlot(some logic moved from FlowRuleManager)ControllertoTrafficShapingControllerto make it clearDescribe how to verify it
See test cases.
Special notes for reviews
None.