Optimizing the click sensitivity of dashboard's side bar menu - #268
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
============================================
+ Coverage 49.83% 50.42% +0.58%
- Complexity 915 922 +7
============================================
Files 158 158
Lines 5259 5259
Branches 757 757
============================================
+ Hits 2621 2652 +31
+ Misses 2306 2262 -44
- Partials 332 345 +13
Continue to review full report at Codecov.
|
Member
|
Nice, thanks for contributing! 👍 |
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
- Use AngularJS binding model directly rather than jQuery DOM-based operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
经测试,控制台左边菜单有不灵敏问题,偶尔出现点击2次才能展开;
复现步骤:
启动控制台,在左边菜单栏点击某个应用,单击中间文字展开,再单击折叠;
然后对准文字右边的向下箭头单击,可能多单击几次,会出现菜单无法展开的情况;
如果有多个应用,点击文字或者箭头展开折叠,多次点击如果点到了箭头也现该情况,
导致主观感觉上有时需要点一下,有时点两下。
Does this pull request fix one issue?
Fixes #245
Describe how you did it
查看sidebar.js的代码,发现里面折叠其它应用菜单的时候,用了element jquery语法,
element.parent().children('ul').hide()
而sidebar.html中向下箭头,相对于菜单文字多了一个层级,如果用parent()加判断不方便;
经向前端同学咨询并查阅了些资料,angular支持数据双向绑定,不推荐直接操作dom;
尝试修改代码,直接遍历修改item.active的值。
参考:
AngularJS折叠菜单实现方法示例 https://www.jb51.net/article/114004.htm
Angular中直接操作DOM https://www.jianshu.com/p/fddd81926e5d
Describe how to verify it
本机启动应用以及在开发、生产环境、按复现步骤多次点击菜单,展开折叠没有出现点两次的情况。
Special notes for reviews