Skip to content

修正closeResources方法中无法打印首次异常 - #2890

Merged
sczyh30 merged 1 commit into
alibaba:masterfrom
hongpy:master
Oct 9, 2022
Merged

修正closeResources方法中无法打印首次异常#2890
sczyh30 merged 1 commit into
alibaba:masterfrom
hongpy:master

Conversation

@hongpy

@hongpy hongpy commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

修改closeResources方法中的if判断

@CLAassistant

CLAassistant commented Sep 26, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sczyh30

sczyh30 commented Sep 26, 2022

Copy link
Copy Markdown
Member

Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=2890

@sczyh30 sczyh30 linked an issue Sep 26, 2022 that may be closed by this pull request
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Sep 26, 2022
@sczyh30

sczyh30 commented Sep 26, 2022

Copy link
Copy Markdown
Member

It could be better if you could add test cases for it as well.

@sczyh30
sczyh30 requested a review from cdfive September 26, 2022 11:23

@cdfive cdfive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pointing it out and help fixing it! @hongpy @sczyh30

@sczyh30
sczyh30 merged commit 5864ab5 into alibaba:master Oct 9, 2022
@sczyh30

sczyh30 commented Oct 9, 2022

Copy link
Copy Markdown
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentinel-core,spi -> SpiLoader-> closeResources方法 有小错误

4 participants