Skip to content

fix print resource name incorrect - #506

Merged
sczyh30 merged 1 commit into
alibaba:masterfrom
laoxingtalk:master
Feb 21, 2019
Merged

fix print resource name incorrect#506
sczyh30 merged 1 commit into
alibaba:masterfrom
laoxingtalk:master

Conversation

@laoxingtalk

Copy link
Copy Markdown
Contributor

Describe what this PR does / why we need it

fix print resource name incorrect

Does this pull request fix one issue?

Fixes #505

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #506 into master will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
- Coverage      38.3%   37.62%   -0.68%     
+ Complexity     1117     1097      -20     
============================================
  Files           259      259              
  Lines          8159     8159              
  Branches       1111     1111              
============================================
- Hits           3125     3070      -55     
- Misses         4631     4697      +66     
+ Partials        403      392      -11
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java 26.04% <0%> (-42.71%) 5% <0%> (-8%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 17.02% <0%> (-21.28%) 4% <0%> (-9%)
...alibaba/csp/sentinel/eagleeye/StatRollingData.java 70.58% <0%> (-2.95%) 8% <0%> (-1%)
...a/com/alibaba/csp/sentinel/eagleeye/StatEntry.java 18.08% <0%> (-2.13%) 7% <0%> (-1%)
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 81.96% <0%> (-1.64%) 28% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 69.62% <0%> (ø) 25% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0fe23...b537bd5. Read the comment docs.

1 similar comment
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #506 into master will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
- Coverage      38.3%   37.62%   -0.68%     
+ Complexity     1117     1097      -20     
============================================
  Files           259      259              
  Lines          8159     8159              
  Branches       1111     1111              
============================================
- Hits           3125     3070      -55     
- Misses         4631     4697      +66     
+ Partials        403      392      -11
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java 26.04% <0%> (-42.71%) 5% <0%> (-8%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 17.02% <0%> (-21.28%) 4% <0%> (-9%)
...alibaba/csp/sentinel/eagleeye/StatRollingData.java 70.58% <0%> (-2.95%) 8% <0%> (-1%)
...a/com/alibaba/csp/sentinel/eagleeye/StatEntry.java 18.08% <0%> (-2.13%) 7% <0%> (-1%)
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 81.96% <0%> (-1.64%) 28% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 69.62% <0%> (ø) 25% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e0fe23...b537bd5. Read the comment docs.

@sczyh30
sczyh30 merged commit f66e90d into alibaba:master Feb 21, 2019
@sczyh30

sczyh30 commented Feb 21, 2019

Copy link
Copy Markdown
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

print resource name is incorrect

3 participants