Refactor Node interface: change return type of QPS get method to double - #564
Merged
Conversation
- Update test cases - Also add `totalPass` method in Node interface Signed-off-by: Eric Zhao <sczyh16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Change return type of
xxxQpsmethod fromlongtodoubleto make it more concise.Note: this is an incompatible breaking change.
Does this pull request fix one issue?
Fixes #242
Describe how you did it
xxxQpsmethod fromlongtodoubleassertEquals(e, a, delta)instead)totalPassmethod in Node interfaceDescribe how to verify it
Run the test cases and demo.
Special notes for reviews
This PR contains breaking changes, please consider it carefully.